Giter Site home page Giter Site logo

Comments (9)

joshgoebel avatar joshgoebel commented on June 2, 2024

We don't generate a sequential list of ranges - it's possible to have deeply nested scopes (a tree). Now if you wanted to walk that tree (and flatten it) to try and build something like this you may want to have a look at https://github.com/wooorm/lowlight instead which users highlight.js but provides guarantees about the output format. Or build the same on us using the same private (but stable) __emitter API that lowlight is using.

Right now though I don't think this CSS API looks very interesting from our point of view - seems to only support single color highlighting... so I can't see why we'd do anything special in the core library to support this.

from highlight.js.

mozesstumpf avatar mozesstumpf commented on June 2, 2024

Thanks for the suggestions, I'll look into it.

Regarding to the Highlight API, I made a little demo how it would work with multiple colors.

https://codepen.io/IDontHaveAny/pen/dyLmvMB

from highlight.js.

joshgoebel avatar joshgoebel commented on June 2, 2024

How does the API handle nested ranges?

from highlight.js.

mozesstumpf avatar mozesstumpf commented on June 2, 2024

What do you mean on "nested ranges"? Could you show me an example?

from highlight.js.

joshgoebel avatar joshgoebel commented on June 2, 2024

"blah #{variable}"

That is variable, within a subst (what we call interpolation), within a string - perhaps even within a "string container" (where the "" are inside the string container but not part of the string itself.

And you can't just flatten there because SOME of the styling of the top-level elements might need to be inherited by the children.

from highlight.js.

mozesstumpf avatar mozesstumpf commented on June 2, 2024

If I understood correctly, your question is whether is it possible to achieve the same style with Ranges that you can manage with the Element nesting or not.

The Highlights (ranges) can be nested so you can accomplish the same result just like when wrapping texts into elements.

https://codepen.io/IDontHaveAny/pen/ExJEGNe

from highlight.js.

joshgoebel avatar joshgoebel commented on June 2, 2024

No I mean something more like a SINGLE string with multiple ranges:

const parentRange = new Range();
parentRange.setStart(parent, 2);
parentRange.setEnd(parent, 14);

const childRange = new Range();
childRange.setStart(parent, 3);
childRange.setEnd(parent, 8);

So here the child is 3-8 while the parent is 2-14, ie the child SHOULD be inside/nested in the parent. I don't understand why you need more elements at all... if you already have elements everywhere it'd easy enough to just use CSS - and avoid the highlighting API entirely.

Feel like I'm still missing something here.

from highlight.js.

mozesstumpf avatar mozesstumpf commented on June 2, 2024

This example was about to show that the ranges can be nested. I don't need to use any element if I could use the Highlight API.

const parentRange = new Range();
parentRange.setStart(parent, 2);
parentRange.setEnd(parent, 14);

const childRange = new Range();
childRange.setStart(parent, 3);
childRange.setEnd(parent, 8);

I'm not sure what you meant by the example above because the ranges are invalid if it's related to the demo.

How does the API handle nested ranges?

Regarding your question, the ranges can be nested in a single string.

I don't understand why you need more elements at all... if you already have elements everywhere it'd easy enough to just use CSS - and avoid the highlighting API entirely.

I'm currently working on a rich text editor where the user can modify the text in the code block, and the code block can strictly contain only a single text node.
Code block example:

<pre>
 <code>
  function example() {}
 </code>
</pre>

from highlight.js.

joshgoebel avatar joshgoebel commented on June 2, 2024

I'm not sure what you meant by the example above because the ranges are invalid if it's related to the demo.

I'm simpying imagining them as indexing into the string...

<------                        full string               ---------->
  "    #{blah_variable_here}. "
  < 2 thru                  18>
       <5 thru           14>

(not to any kind of scale, lol)

from highlight.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.