Webpack minimize causes cbor.encode to generate a different value

[noway]

Webpack minimize causes cbor.encode to generate a different value

[hildjj]

This is likely because the Buffer implementation you're using outside of the WebPack'd code is different from the one inside. The one inside got mangled, and the one outside didn't, so when node-cbor is trying to find out "is this a Buffer?" it doesn't get a match. This leads to the buffer being encoded as a plain object, which, if I recall correctly, serializes it as a string with comma-delimited decimal numbers, one per byte -- which will be much larger than the correct serialization.

To fix this, either pack all of your code together, or export the Buffer implementation from inside the packed code, then use that in your unpacked code. There are likely other ways to fix it, but let's see if this hypothesis proves out first.

[noway]

You're right, Buffer.name gets mangled and the encoding can't find a proper converter. I'll make a PR.

[hildjj]

Can you try passing in a genTypes option into the Encoder instance?

Encoder.encodeOne(Buffer.alloc(2), { genTypes: [Buffer, Encoder._pushBuffer] });

and if that doesn't work, try:

Encoder.encodeOne(Buffer.alloc(2), { genTypes: [Buffer.name, Encoder._pushBuffer] });

[noway]

That worked! Passing in my implementation of Buffer from import { Buffer } from "buffer" package using genTypes worked for me. Now I don't need the patch in #166

I gonna close that pull request since this workaround solves it.

[noway]

Here's how i've done it: vaxxnz/nzcp-js#60