Comments (6)
Haha - can you tell I'm just starting to learn Javascript development? 😉. Lets go with ES2015 (as long as that won't have too many compatibility issues??). Happy to hear your thoughts on what would be more appropriate though.
I must of been thinking let
was actually const
. Oops!
from tldr-chrome.
Personally I've had more experience with standard JavaScript. But I think ES2015 has a nicer(?) syntax and more functionality.
As far as I know though, ES2015/16 has to be transpiled to ES5 for browser compatibility. (I'm not sure what the support is in Chrome).
As this uses the new web extension format, it depends if you want to also support Firefox too as they can use most of the same content for extensions.
I guess to be honest it's what you're comfortable, as the primary contributor. 👍
from tldr-chrome.
I've had a go over here in a feature branch: feature/es2015-refactor
It looks like it doesn't need transpiling so far.
sigh Interestingly, although it doesn't need semicolons, it still seems to be recommended by linters, just not by Google standards.
from tldr-chrome.
@hill, also, this is unrelated to the issue, will you be adding tags for each release?
i.e.
git tag v0.1.0 5f2eb00d4ee415e243efdd8a9df6c364d03fd1e2
git tag v0.2.0 676ae08986a66cbde9c32807ac4b6ecc940e3585
from tldr-chrome.
@pxgamer yep that branch looks much cleaner! If it doesn't need transpiling then let's go with that.
I haven't used tags before - I'll certainly look into it. Is there a particular benefit it provides?
from tldr-chrome.
@hill, if you're happy with it, I'll create a pull request 👍
And regarding tags, the only reason was that if there is a stable version, it allows you to see what changes were made per version, and also download a .zip
or .tar.gz
of that exact version (example). The other good thing about it is that anyone can see what versions there are using git tag
.
from tldr-chrome.
Related Issues (6)
- This extension is aging - anyone want to keep this cool extension updated? HOT 15
- External stylesheet with unique id HOT 7
- Implement Fetch over XMLHttpRequest
- Ensure tooltip does not disappear when clicking inside the tooltip HOT 2
- This app 's tl;dr info is out-of-date from the master repo at https://github.com/tldr-pages/tldr-pages.github.io HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tldr-chrome.