Import 'github.com/hillu/go-yara/internal/callbackdata" makes forking harder

[hillu]

Import 'github.com/hillu/go-yara/internal/callbackdata" makes forking harder

[hillu]

@plusvic I wouldn't call it a worry as such, but I consider the Go library ecosystem a fragile, botched mess (and I'm afraid I don't think that the newly introduced "modules" will make things much better, so I'd prefer to keep go-yara self-contained (except for the libyara bit of course.)

I think I'm just going to move the "internal" stuff back into the main package.

[hillu]

Argh, I should have seen that one coming. Do you see any solution that does not add an external dependency and that does not move the callback-related code back into the main package?

[plusvic]

I can't find a solution that doesn't involve having an external dependency. What's your worry about the external dependency?

[plusvic]

Yep, I support the idea of keeping it as self-contained as possible.