Giter Site home page Giter Site logo

Comments (4)

jimsmith avatar jimsmith commented on July 25, 2024

more than 2 years old, if not getting progressed then close ?

from hipchat-cli.

ilikepi avatar ilikepi commented on July 25, 2024

@jimsmith This repo hasn't been touched in over 2 years. If Atlassian isn't going to make further contributions to it, that's their decision. There is still value in having the repo exist as a starting point to others who need to use the functionality provided by the script. For the sake of those people, it makes sense to me to keep the existing issues open in order to highlight them.

from hipchat-cli.

dkolbly avatar dkolbly commented on July 25, 2024

@ilikepi As much as I like the cleaner alternative of just stating that html-formatted messages are, well, HTML-formatted (i.e., regarding it as a bug that we mark up URLs in supposedly already HTML messages), I'm worried about the breakage that might cause. I think some people use the HTML mode to do inline markup like <code> or <b> or whatever, but rely on the URL detection for link markup.

If you are willing to issue a PR with your simple fix, I think that'd be great. There's some subtlety to the RE, I suppose, because Perl doesn't like a variable-length ?<! (lookbehind) assertion.

from hipchat-cli.

dkolbly avatar dkolbly commented on July 25, 2024

Thanks @ilikepi I went ahead and fixed this in #40. I'm not a perl RE wizard, but just making sure the src part was the same length as the href part by prefixing a space seemed to work fine.

from hipchat-cli.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.