Giter Site home page Giter Site logo

Comments (4)

HiPhish avatar HiPhish commented on July 23, 2024 4

Can you please check the current master? There has been a major update and it might have fixed the problem as a side effect.

By my understanding at least three other projects were created by others which had ultimately been archived

To be honest, I can't blame them. All pre-Treesitter projects were doomed from the start, there is only so far you can get with regex hackery before the cracks start forming. p00f/nvim-ts-rainbow had potential, but the author was trying to do too much with as little code as possible. That's generally a good thing, but languages are too different that you could rule them all with one query, you get too many edge cases you have to wrestle with.

When he abandoned it I forked the project (HiPhish/nvim-ts-rainbow2) in March this year. My fork split queries and strategies out from the core. This means we have to write a completely new query for each language, but it also means fewer edge cases.

And then I forked that fork again in July of this year because of changes in nvim-treesitter. And just today I have merged a massive refactoring. It's beautiful, finally HTML tags can have proper highlighting. Highlighting delimiters is not hard in itself, but there are weird edge cases when it comes to nested languages.

Please don't misunderstand me, I'm not whining. I have wanted a plugin like this even back when I was using Vim before Neovim even existed, I just never imagined I would be the one maintaining it. I find the journey fascinating.

from rainbow-delimiters.nvim.

HiPhish avatar HiPhish commented on July 23, 2024

Do you have the comment grammar installed? That parser will create a separate node for each - or " and each word inside the comment. Please try without the comment grammar first if you have it installed.

from rainbow-delimiters.nvim.

wrbright avatar wrbright commented on July 23, 2024

Thank you for you're response,

I can confirm that the issue is only present when the comment grammar is installed, and uninstalling it does fix the issue. Is this plugin incompatible with the comment grammar?

from rainbow-delimiters.nvim.

wrbright avatar wrbright commented on July 23, 2024

I can also confirm that blacklisting "comment" does fix this issue, while allowing the parser to remain installed.

For anyone looking at this later on, this is the config within lua to achieve this:

vim.g.rainbow_delimiters = {
	blacklist = {
		"comment"
	}
}

Thank you, by the way, for maintaining this project. By my understanding at least three other projects were created by others which had ultimately been archived, I appreciate your effort in keeping this alive.

from rainbow-delimiters.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.