Giter Site home page Giter Site logo

Comments (22)

peckover avatar peckover commented on July 28, 2024 1

Hi Luke
Thank you for the quick reply. We think we have identified a separate issue. We are working on this as a priority and will update when a new fix is out.
Cheers
Johnny
DDCTLS Team

from vat-api.

LukeHirst avatar LukeHirst commented on July 28, 2024

I have looked through the closed issues and seen this post:

/issues/873

I therefore tried to do a submission with an organisation created from the following URL:

https://developer.service.hmrc.gov.uk/api-test-user

I still get internal server error (endpoint, request body and response are below):

https://test-api.service.hmrc.gov.uk/organisations/vat/722605949/returns

{"periodKey":"18A2","vatDueSales":1905.64,"vatDueAcquisitions":0.00,"totalVatDue":1905.64,"vatReclaimedCurrPeriod":990.00,"netVatDue":915.64,"totalValueSalesExVAT":13598.0,"totalValuePurchasesExVAT":6467.0,"totalValueGoodsSuppliedExVAT":0.0,"totalAcquisitionsExVAT":0.0,"finalised":true}

{"code":"INTERNAL_SERVER_ERROR","message":"An internal server error occurred"}

I do have my own code to create an organisation which only adds the "mtd-vat" scope however this was previously working when we last tested using the sandbox.

from vat-api.

DDCTLS-DEV-TEAM avatar DDCTLS-DEV-TEAM commented on July 28, 2024

Good Morning @LukeHirst

Apologies for the late reply on this one.
We would be more than happy to help get to the bottom of this one.
We have had a look at the errors in the sandbox environment and it looks like the only ones we are getting are Unauthorised insufficient enrolments or unsupported enrolments.

We have created a user with mtd-vat only and used your JSON above and it looks like it works for us. Could you do me a favor please and hit it again can you make a note of the exact time you hit it and hopefully we can narrow down your request and iron out this issue for you.

Kind Regards
DDCTLS Team

from vat-api.

LukeHirst avatar LukeHirst commented on July 28, 2024

@DDCTLS-DEV-TEAM

It is still returning error 500, below is the correlationId which should unique to the request:

CorrelationId = d19a7cea-cf61-438b-b8fb-adfcd0693b46

Would this be good enough to track it?

from vat-api.

peckover avatar peckover commented on July 28, 2024

Good morning Luke,

The correlationId was helpful, thank you. We have just pushed out a change that will hopefully solve your issue. Could you try again and see if the issue is resolved please?

Cheers,
Johnny
DDCTLS Team

from vat-api.

LukeHirst avatar LukeHirst commented on July 28, 2024

@DDCTLS-DEV-TEAM Hello Johnny,

I am still get the error 500, correlation ID as below:

a8de603a-28c0-46ee-ab97-126322ff45a5

Is this fix conditional on creating a new organisation or something?

from vat-api.

bcroston avatar bcroston commented on July 28, 2024

I'm also having exactly the same problem with a 500 error when submitting a return to the sandbox.

from vat-api.

DDCTLS-DEV-TEAM avatar DDCTLS-DEV-TEAM commented on July 28, 2024

Good Morning @LukeHirst and @bcroston,

We have implemented a change that should fix the issue.
Can you please try again and update us.

Thank you in advance.

DDCTLS Team

from vat-api.

bcroston avatar bcroston commented on July 28, 2024

I'm still getting the same 500 error

from vat-api.

DDCTLS-DEV-TEAM avatar DDCTLS-DEV-TEAM commented on July 28, 2024

@bcroston Can you please provide correlation-id or VRN ?

from vat-api.

bcroston avatar bcroston commented on July 28, 2024

VRN ix 646015553
It's giving me a 500 error before I get a correlation-id

from vat-api.

DDCTLS-DEV-TEAM avatar DDCTLS-DEV-TEAM commented on July 28, 2024

Hello @bcroston
Looking at the logs you are getting a 500 response when authenticating. This is most likely why you don't get to the correlation-id part of the vat-API service.

Can you confirm how you're setting up a user please and whether this has worked for you in the past?

Thank you in advance
DDCTLS Team

from vat-api.

bcroston avatar bcroston commented on July 28, 2024

I created the test user a long time ago (1 year plus) and can't remember doing it. I will create a new test user using the API and see what happens.

from vat-api.

DDCTLS-DEV-TEAM avatar DDCTLS-DEV-TEAM commented on July 28, 2024

@bcroston thank you

from vat-api.

bcroston avatar bcroston commented on July 28, 2024

A new test user has fixed the problem for me.

from vat-api.

DDCTLS-DEV-TEAM avatar DDCTLS-DEV-TEAM commented on July 28, 2024

@bcroston Happy to hear it.
Thank you for reaching out to us.

@LukeHirst do you have an update on your side?

Thank you in advance
DDCTLS Team

from vat-api.

LukeHirst avatar LukeHirst commented on July 28, 2024

@DDCTLS-DEV-TEAM I have regenerated my user from both website and my own test program but still get internal server error, correlation ID as below:

624f2da2-4ccd-48be-a1f7-d9245598dad2

from vat-api.

DDCTLS-DEV-TEAM avatar DDCTLS-DEV-TEAM commented on July 28, 2024

Hello @LukeHirst ,

Can you tell us the headers you are using please?

Thank you

from vat-api.

LukeHirst avatar LukeHirst commented on July 28, 2024

@DDCTLS-DEV-TEAM

I am using the following URL:

https://test-api.service.hmrc.gov.uk/organisations/vat/589531983/returns

Headers:

  • Authorization = Bearer VALIDTOKEN
  • Accept = {application/vnd.hmrc.1.0+json}
  • Gov-Test-Scenario = ""

I am also sending fraud prevention headers however I am not sure if it's relevant to list them as we don't usually get a response about them on this github

from vat-api.

LukeHirst avatar LukeHirst commented on July 28, 2024

@DDCTLS-DEV-TEAM

I have managed to submit a return successfully by removing the blank Gov-Test-Scenario header. This used to work previously with an empty string but now needs to be omitted if there is no value

from vat-api.

DDCTLS-DEV-TEAM avatar DDCTLS-DEV-TEAM commented on July 28, 2024

@LukeHirst
Perfect we were about to suggest "-" on the Gov-Test-Scenario header.
If you would like to try that as well that would work too. (Or should)
If you are happy we will close the issue?
Thank you.
DDCTLS Team

from vat-api.

LukeHirst avatar LukeHirst commented on July 28, 2024

Yes, I have closed this issue

from vat-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.