Giter Site home page Giter Site logo

[ENTRY-TYPE] Setting the same name that you give to the entry type as the one that you give to an enum that's in one of its fields generates broken code about scaffolding HOT 3 CLOSED

guillemcordoba avatar guillemcordoba commented on May 30, 2024
[ENTRY-TYPE] Setting the same name that you give to the entry type as the one that you give to an enum that's in one of its fields generates broken code

from scaffolding.

Comments (3)

c12i avatar c12i commented on May 30, 2024

I see, this is what ends up generated

pub enum Status {
    Null,
}
#[hdk_entry_helper]
#[derive(Clone, PartialEq)]
pub struct Status {
    pub status: Status,
}

Two ways I can see this getting fixed, either prevent the user from setting the name of the enum as the name of the entry type or add a suffix Enum to each rust enum generated to ensure the names are always unique

I lean more towards the first approach

from scaffolding.

c12i avatar c12i commented on May 30, 2024

I also noticed that it's possible to input multiple of the same enum variants, which also produces broken code

#[derive(Serialize, Deserialize, Debug, Clone, PartialEq)]
#[serde(tag = "type")]
pub enum FooEnum {
    Bar,
    Bar,
    Bar,
}

from scaffolding.

guillemcordoba avatar guillemcordoba commented on May 30, 2024

👍

from scaffolding.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.