Bug: Translation between coordinates

[holoviz]

Bug: Translation between coordinates

[philippjfr]

Thanks for reporting this, seems as if the indices are getting reversed. I'll push a fix in the next few minutes.

[jbednar]

That was definitely something I was worried about, because our tested notebooks nearly all use square plots by default. Not sure how to test this better in general, without supplying non-square dimensions explicitly to every example...

[philippjfr]

It's taking a bit longer as Raster and Image obviously have different coordinate spaces. I'll think about it a bit more tonight and hopefully come up with a clean fix by tomorrow.

[philippjfr]

Just pushed a fix for this, sampling of non-square Raster and Image Elements is now handled correctly. In fact the problem went a lot deeper than it appeared. Indexing of our Elements always happens by the order of dimensions so when indexing into a Raster type, the first index will map onto the x-axis. This was previously inverted. Additionally the xdensity and ydensity on Images was also inverted resulting in the index errors you see above. This should all be fixed now, the Continuous_Coordinates tutorial is updated and I added a few unit tests.

[philippjfr]

Once the associated Travis tests for these commits pass I will close this issue.