Python package virtualenv as a dependency

[homebridge]

Python package virtualenv as a dependency

[NorthernMan54]

PS I would gladly update mine to yours, if it was faster!!!!

[NorthernMan54]

Build has been kicked off, it should take about an hour, and a release will be created in the test environment

https://github.com/NorthernMan54/homebridge-apt-pkg/actions/runs/6981891690

Release target to be populated

https://github.com/NorthernMan54/homebridge-apt-pkg/releases/tag/1.20.2

[maxileith]

Everything is working fine on a fresh install with Homebridge 1.1.4 from the official repository. 🎉

[NorthernMan54]

Docker image was published a few minutes ago, and the homebridge-raspbian-image is in progress, it usually takes a few hours

[NorthernMan54]

Are you also going to resolve the sluggishness of the pyatv package with this approach ?

FYI - My version of the same - https://github.com/NorthernMan54/homebridge-cmd-television
Which I use to be able to tell Siri and Alexa to pause and resume TV

I will be updating those packages next month, and can include. Will need assistance around testing though

[maxileith]

Hi @NorthernMan54,

I did no experience any problems regarding pyatv besides incompatibility with Python 3.11 which I have fixed with this PR postlund/pyatv#2270.

The plugin that I have written is very fast. We are talking <<1s response time. So it is most likely an implementation problem. I cannot look at you source code since there is no source code in your repo.

However, from what I can tell from the README your installation, pairing and configuration looks largely manual in contrast to my plugin. As I said, my plugin is installing the venv, the requirements automatically and the pairing process is done without the need to go to the CLI (After autodiscovery of Apple TVs). The pairing process is happening in a web application that is hosted by the plugin when pairing. All the credentials as well as the appletv configs are stored in the userstorage path.

[maxileith]

@NorthernMan54 I just saw the index.js, so source code is checked in. However, the points from my comment before are still valid.

[NorthernMan54]

What I found was that the atvremote commands were sluggish as they negotiated authentication every time ( this was about 18 months ago )

ie

time atvremote --id 08:66:98:D4:CF:79 --airplay-credentials `cat ~/.homebridge/atv_airplay.cred` --companion-credentials `cat ~/.homebridge/atv_companion.cred` pause

real	0m1.961s
user	0m1.535s
sys	0m0.249s

[maxileith]

@NorthernMan54 not the right place to discuss that. Please only comment if you have comments on the topic that I have created this issue for.

[maxileith]

@NorthernMan54 I didn't want to deter you away from the discussion, I just wanted to make sure this issue was about what I opened it for. We can discuss if it makes sense to ship the mentioned python3-venv package with homebridge or not. The discussion about whether pyatv for a verified plugin should then be discussed in the issue about verification. The message before was a bit harsh, sorry for that ...

[NorthernMan54]

I have added python3-venv to the test area for the next Homebridge-apt-pkg. Can you take a moment and test it to ensure that everything is okay for your plugin.

https://github.com/NorthernMan54/homebridge-apt-pkg/releases/tag/1.20.1

You should be able to downland the appropriate DEB file, and install it with apt-get install ./homebridge....

[maxileith]

@NorthernMan54 That sounds awesome. I will test it on a fresh Raspberry PI OS Bookworm installation and let you know if it is working :)

[maxileith]

So I just tried it on a Raspberry Pi 3 with Pi OS Bookworm 64-bit installed on it. Regarding the virtual environment everything works fine. python3-venv is installed as a dependency and my plugin can create the virtual python environment for itself without any issues.

However, there are problems occuring when installing the python depdencies. Not all dependencies are built for every system architecture, e.g. arm64. Therefore pip tries to build them on itself which requires python3-dev. I simplly did not recongnize that on my productive and development system since I have installed this package on these systems anyways. Would it be possible to include python3-dev in the dependencies as well?

However, I would like to mention that adding python3-venv is a benefit even without python3-dev, especially for users of systems for which the packages are already built. The python3-dev package is only necessary for those for whom not all python packages are prebuilt.

[NorthernMan54]

FYI - I moved to the package we are working with

Does installing python3-dev then require compiling code, and a build environment as well ?

The raspbian image and docker image both leverage this package, so the change only needs to be made in one place

[maxileith]

@NorthernMan54 yes, this does mean that there has to be code compiled. In the case of Raspberry Pi OS Lite 64-bit the build tools were already installed. Installing python3-dev was sufficient.

[maxileith]

I have made another fresh Pi OS install and can confirm that everything is working with v1.20.2. 👍🏻

[NorthernMan54]

I just merged and published this as 1.1.4. can you check that production version out, then I will release the other packages.