Plugin Review Request for homebridge-scout

[homebridge]

Plugin Review Request for homebridge-scout

[BewhiskeredBard]

Thanks for reviewing so quickly. It's going to take a bit of refactoring to push config validation into the platform constructor so that it doesn't crash. I'll try to have a new release out in the next few days and will comment here when I do.

[oznu]

• - The plugin must successfully install.
• - The plugin must impliment the Homebridge Plugin Settings GUI.
• - The plugin must not start unless it is configured.
• - The plugin must not execute postinstall scripts that modify the users system in any way.
• - The plugin must not contain any analytics or calls that enable you to track the user.
• - The plugin must not throw unhandled exceptions, the plugin must catch and log it's own errors.
• - The plugin must be published to npm and the source code available on GitHub.
• - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v10 and v12.
• - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
• - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

---

The plugin must not throw unhandled exceptions, the plugin must catch and log it's own errors.

If not all the modes are provided the following error is thrown which crashes Homebridge. The errors should be caught and logged instead of crashing Homebridge.

[3/30/2020, 20:16:01] [ScoutAlarm] Running homebridge-scout-1.0.0 on homebridge-0.4.53.
[3/30/2020, 20:16:01] Error: Configuration error: config.modes should have required property 'away'
    at HomebridgeContextFactory.create (/Users/john/src/homebridge/homebridge-scout/lib/context/homebridge.js:20:19)
[3/30/2020, 20:16:01] Got SIGTERM, shutting down Homebridge...

Everything else looks good 😄

[BewhiskeredBard]

I just released version 1.0.1 to npm with the fix.

[oznu]

Looking good.