Comments (3)
- - The plugin must successfully install.
- - The plugin must impliment the Homebridge Plugin Settings GUI.
- - The plugin must not start unless it is configured.
- - The plugin must not execute postinstall scripts that modify the users system in any way.
- - The plugin must not contain any analytics or calls that enable you to track the user.
- - The plugin must not throw unhandled exceptions, the plugin must catch and log it's own errors.
- - The plugin must be published to npm and the source code available on GitHub.
- - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v10 and v12.
- - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
- - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
The plugin must not throw unhandled exceptions, the plugin must catch and log it's own errors.
If the plugin is cannot parse the apple tv credentials it will crash Homebridge here:
TypeError [ERR_INVALID_ARG_TYPE]: The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type undefined
at Function.from (buffer.js:293:9)
at Function.parse (node-appletv-x/dist/lib/credentials.js:21:49)
at Object.parseCredentials (node-appletv-x/dist/index.js:31:38)
[4/7/2020, 21:22:25] Got SIGTERM, shutting down Homebridge...
[4/7/2020, 21:22:25] [Apple TV Platform] Shutting down Apple TV clients...
You should catch and log these errors to prevent Homebridge from shutting down if an exeception is thrown here.
You might also like to include a link to your GitHub README in the header or footer of the config.schema.json
letting people know they can go there for instructions on how to pair. These fields accept markdown.
Everything else looks good 😄
from verified.
- I added a check if credentials can be parsed right at the beginning when the config is loaded and devices are initialized.
- Hint on how to create credentials (link to the GitHub repo) is now in the config.schema.json header.
from verified.
Thanks!
from verified.
Related Issues (20)
- homebridge-purpleair HOT 8
- homebridge-switchbot-sensor-ble HOT 22
- homebridge-davis HOT 11
- homebridge-rademacher-homepilot HOT 16
- homebridge-actron-neo HOT 7
- homebridge-mqttsmokesensor HOT 5
- homebridge-mqttsmokesensor HOT 7
- homebridge-actron-neo HOT 6
- homebridge-gree-ac HOT 35
- homebridge-panasonic-cloud-platform HOT 12
- homebridge-RedAlertViaKumta HOT 17
- homebridge-yokis-http-client HOT 3
- homebridge-airtouch5-platform HOT 18
- homebridge-ngbs-icon-thermostat HOT 21
- homebridge-yeelight-ble HOT 11
- [test] homebridge-ewelink HOT 21
- homebridge-airport-express-playing unverification HOT 6
- Homebridge Switchbot Reloaded HOT 4
- homebridge-hyperion HOT 4
- homebridge-shelly-blu HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from verified.