homebridge-resol-vbus

[ChristophFausak]

homebridge-resol-vbus

[github-actions]

✅ Pre-checks completed successfully.

[bwp91]

Hi @ChristophFausak

As part of the checks I make, I install the plugin, open the config screen and click save without making any changes. This resulted in the following config:

        {
            "name": "Resol VBus Platform",
            "servers": [
                {
                    "connectionOptions": {
                        "path": "/dev/ttyACM0"
                    },
                    "connectionClassName": "TcpConnection"
                }
            ],
            "platform": "ResolVBus"
        }

And this sent Homebridge into a crash loop:

[17/04/2023, 21:32:33] Error: Unable to connect
    at onSocketTermination (/usr/local/lib/node_modules/homebridge-resol-vbus/node_modules/resol-vbus/src/tcp-connection.js:334:26)
    at Socket.onError (/usr/local/lib/node_modules/homebridge-resol-vbus/node_modules/resol-vbus/src/tcp-connection.js:363:17)
    at Socket.emit (node:events:513:28)
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
[17/04/2023, 21:32:33] Got SIGTERM, shutting down Homebridge...

This needs to be fixed (error caught within the plugin and the plugin logs the issue and 'stops') so that it does not affect other plugins!

[ChristophFausak]

Thanks, @bwp91 !

pls. check version 1.1.4

[bwp91]

Okay great, updated and it is no longer crashing homebridge which is the main thing!

Next one: with a config of this, (and I now have this plugin in a child bridge but have removed this bridge part from the config):

        {
            "name": "Resol VBus Platform",
            "servers": [
                {
                    "connectionOptions": {
                        "path": "jfkdsjfklds",
                        "host": "192.168.4.1"
                    },
                    "name": "jkl",
                    "autoDiscover": true,
                    "connectionClassName": "SerialConnection"
                }
            ],
            "platform": "ResolVBus"
        }

The child bridge is constantly restarting:

[19/04/2023, 22:44:57] [Resol VBus Platform] Child bridge process ended
[19/04/2023, 22:44:57] [Resol VBus Platform] Process Ended. Code: 1, Signal: null
[19/04/2023, 22:45:04] [Resol VBus Platform] Restarting Process...
[19/04/2023, 22:45:05] [Resol VBus Platform] Launched child bridge with PID 31900
[19/04/2023, 22:45:07] Registering platform 'homebridge-resol-vbus.ResolVBus'
[19/04/2023, 22:45:07] [Resol VBus Platform] Loaded homebridge-resol-vbus v1.1.4 child bridge successfully
[19/04/2023, 22:45:07] Loaded 0 cached accessories from cachedAccessories.0E67B266B231.
Error: Error: No such file or directory, cannot open jfkdsjfklds
[19/04/2023, 22:45:08] [Resol VBus Platform] Child bridge process ended
[19/04/2023, 22:45:08] [Resol VBus Platform] Process Ended. Code: 1, Signal: null
[19/04/2023, 22:45:15] [Resol VBus Platform] Restarting Process...
[19/04/2023, 22:45:16] [Resol VBus Platform] Launched child bridge with PID 31911
[19/04/2023, 22:45:18] Registering platform 'homebridge-resol-vbus.ResolVBus'
[19/04/2023, 22:45:18] [Resol VBus Platform] Loaded homebridge-resol-vbus v1.1.4 child bridge successfully
[19/04/2023, 22:45:18] Loaded 0 cached accessories from cachedAccessories.0E67B266B231.
Error: Error: No such file or directory, cannot open jfkdsjfklds
[19/04/2023, 22:45:18] [Resol VBus Platform] Child bridge process ended
[19/04/2023, 22:45:18] [Resol VBus Platform] Process Ended. Code: 1, Signal: null
[19/04/2023, 22:45:25] [Resol VBus Platform] Restarting Process...
[19/04/2023, 22:45:27] [Resol VBus Platform] Launched child bridge with PID 31922
[19/04/2023, 22:45:29] Registering platform 'homebridge-resol-vbus.ResolVBus'
[19/04/2023, 22:45:29] [Resol VBus Platform] Loaded homebridge-resol-vbus v1.1.4 child bridge successfully
[19/04/2023, 22:45:29] Loaded 0 cached accessories from cachedAccessories.0E67B266B231.
Error: Error: No such file or directory, cannot open jfkdsjfklds
[19/04/2023, 22:45:29] [Resol VBus Platform] Child bridge process ended

This may seem like a strange config for me to have, and unrealistic too(!), but the main thing here is to make sure that your plugin catches all errors and deals with them appropriately, rather than crashing the node process (which could affect other plugins).

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions]

This issue has been closed as no further activity has occurred.