homebridge-blinds

[homebridge]

homebridge-blinds

[donavanbecker]

@donavanbecker I'm somewhat mixed on adding these (just because these variables can be so specific), but it doesn't hurt. See: dxdc/homebridge-blinds@53216c0

not that the placeholder is a requirement, but I feel like it helps to understand what is expected in those fields. If you decide to remove it, that's up to you.

Thanks for making those changes!

[github-actions]

✅ Pre-checks completed successfully.

[donavanbecker]

• - The plugin must successfully install.
• - The plugin must implement the Homebridge Plugin Settings GUI.
• - The plugin must not start unless it is configured.
• - The plugin must not execute post-install scripts that modify the user's system in any way.
• - The plugin must not contain any analytics or calls that enable you to track the user.
• - The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
• - The plugin must be published to npm and the source code available on GitHub.
• - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v10 and v12.
• - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
• - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

---

The plugin must implement the Homebridge Plugin Settings GUI.

Awesome Plugin @dxdc, can I suggest one change to your config?

• add the placeholder parameter, "placeholder": "http://1.2.3.4/window/up",

This will make it easier to know what format should be used for each field.

[dxdc]

@donavanbecker thanks for your review! How is this?

dxdc/homebridge-blinds@50bd318

[donavanbecker]

@dxdc looking better! think there should be one for "position_jsonata":?

[dxdc]

@donavanbecker I'm somewhat mixed on adding these (just because these variables can be so specific), but it doesn't hurt. See: dxdc/homebridge-blinds@53216c0

[donavanbecker]

/check

[github-actions]

✅ Pre-checks completed successfully.

[donavanbecker]