homebridge-eggtimer-plugin

[teh-hippo]

homebridge-eggtimer-plugin

[bwp91]

Hi @teh-hippo first of all thanks for the PR on this repo earlier!

Plugin looks good, the only thing I would suggest is githib releases with tags as v${npmVersion} i mean if npm release is 1.2.3 then github tag (with release) is v1.2.3. I think this helps with showing release notes in the homebridge ui, but I could be wrong here!

[github-actions]

The following pre-checks failed:

❌ Failed to test plugin.
❌ Command failed: docker build -t check .

Comment /check to run checks again.

[teh-hippo]

/check

[github-actions]

The following pre-checks failed:

❌ Failed to test plugin.
❌ Command failed: docker build -t check .

Comment /check to run checks again.

[bwp91]

/check

[github-actions]

✅ Pre-checks completed successfully.

[github-actions]

Congratulations! Your plugin has been verified.

You can now add the Verified by Homebridge badge to your plugin's README:

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/oznu/homebridge-config-ui-x/wiki/Developers:-Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Thank you for your contribution to the Homebridge Community.
https://homebridge.io

[teh-hippo]

Hi @teh-hippo first of all thanks for the PR on this repo earlier!

Plugin looks good, the only thing I would suggest is githib releases with tags as v${npmVersion} i mean if npm release is 1.2.3 then github tag (with release) is v1.2.3. I think this helps with showing release notes in the homebridge ui, but I could be wrong here!

Not a problem, was interesting to see how structured and organised the whole operation of verifying is!

Thanks for the suggestion with the tag. It's actually the first time I've done github actions myself from scratch - always utilised them, or they've already been in place. I tried to be all fancy at first and then decided that fell into the "too hard basket" for now. v1.2.3 vs 1.2.3 was a slip-up, but will see if I can correct at some stage. :)

[bwp91]

Oh don’t worry about correcting stuff, my comment was about stuff for the future 🙂