Giter Site home page Giter Site logo

Comments (8)

bwp91 avatar bwp91 commented on June 16, 2024 1

thanks for the changes!

not sure if this suits your use case for the IP address config field, but there exists a format: 'ipv4' property you can use for a little bit more guidance in the plugin config screen for users.

https://developers.homebridge.io/#/config-schema#format

Will show a warning in the config screen if any entered value does not seem a valid IP

from verified.

tomas-kulhanek avatar tomas-kulhanek commented on June 16, 2024 1

@bwp91 thanks!
I modified the format and released a new version.

from verified.

github-actions avatar github-actions commented on June 16, 2024

✅ Pre-checks completed successfully.

from verified.

bwp91 avatar bwp91 commented on June 16, 2024

Hi @tomas-kulhanek

Please update your readme with a valid config for your plugin (it at least needs to include the "platform" property, and in the case of your readme example, it would be good to see a 'base, minimal' config as well as one that shows a config for a vacuum cleaner with room cleaning as you have written in your current readme


screenshot:
Screenshot 2023-07-11 at 01 50 31


from verified.

bwp91 avatar bwp91 commented on June 16, 2024

Comment number two:

I have installed the plugin on my local homebridge with the following config:

        {
            "platform": "Shelly2PMPlus",
            "_bridge": {
                "username": "0XXX",
                "port": XXX
            }
        }

I get the following message in the log

[11/07/2023, 01:49:51] [homebridge-shelly-2pm-plus] Initialize of plugin was failed TypeError: this.config.watch is not iterable

which is great that the plugin 'stops' and is one of the main things about verified plugins, but I wonder if a more helpful explanation for the user would help.

This is outside the plugin verification criteria but if you are sorting out the above anyway 😁

from verified.

tomas-kulhanek avatar tomas-kulhanek commented on June 16, 2024

Hi @bwp91
OMG 🤦 , I have information about a vacuum cleaner there, and it's an electronic voltage switch 😁

I edited it incl. platform definition in the configuration and I treated the type error for watch straight away

from verified.

github-actions avatar github-actions commented on June 16, 2024
  • - The plugin must successfully install.
  • - The plugin must implement the Homebridge Plugin Settings GUI.
  • - The plugin must not start unless it is configured.
  • - The plugin must not execute post-install scripts that modify the user's system in any way.
  • - The plugin must not contain any analytics or calls that enable you to track the user.
  • - The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
  • - The plugin must be published to npm and the source code available on GitHub.
  • - GitHub releases should be created for every new version of your plugin, with patch notes.
  • - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v16 and v18.
  • - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
  • - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

Everything Looks Good!

from verified.

github-actions avatar github-actions commented on June 16, 2024

Congratulations! Your plugin has been verified.

You can now add the Verified by Homebridge badge to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/oznu/homebridge-config-ui-x/wiki/Developers:-Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Thank you for your contribution to the Homebridge Community.
https://homebridge.io

from verified.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.