Double notification in example React app

[honeybadger-io]

Double notification in example React app

[JasonTrue]

This is a bit funky. Looks like what's going on is the react version gets thrown, then the standard window.onerror handler catches it as well and it gets rethrown (so without the React context stuff). I can't recommend turning off the window.onerror handler, because there are some cases when errors aren't handled by the error boundary, but I'm not sure how to prevent the error from being rethrown. Hopefully there's some quick fix but it'll take a bit of research.

[JasonTrue]

I've determined that this is "expected, even if surprising" behavior in debug builds of React applications. There's an explanation here:

https://www.bountysource.com/issues/48334950-the-fake-event-trick-for-rethrowing-errors-in-dev-
fires-unexpected-global-error-handlers-and-makes-testing-harder

I don't believe it's worth the convoluted workaround to handle something that will be of no consequence in a production build, especially in a service designed primarily to monitor production exceptions. So I'm going to close this as "by design," and update the honeybadger docs to reflect the potentially confusing behavior.

A version of the example app built for production is hosted at https://jasontrue.github.io/honeybadger-react/ and does not reproduce the issue; we can decide later whether to link to that or create another alternate hosted location for an example app.