Port to python 3

[honeynet]

Port to python 3

[ClaudiuGeorgiu]

Hi, I would like to help with this, do you have any roadmap?

[yuanchun-li]

Thank you very much @ClaudiuGeorgiu .
I don't have a roadmap for this. Could you install and test DroidBot with Python 3 and see what happens?

[ClaudiuGeorgiu]

Sure, I will test it in the next days and I will report here the results.

[ClaudiuGeorgiu]

Hi, I've started updating the code (https://github.com/ClaudiuGeorgiu/droidbot/commits/python3). It looks like that the last version of androguard introduced some changes in how the manifest is handled so droidbot needs to be updated accordingly. I'll investigate more in the next days and I'll report back here the progress.

[ClaudiuGeorgiu]

Hi @ylimit, I've finally managed to run DroidBot with Python3 but I don't think the changes are compatible with Python2 (I wasn't interested in maintaining the compatibility). I'm going to continue working on my fork of DroidBot to do some minor refactoring/add some minor features for my use case, so let me know if you are interested in a pull request.

[yuanchun-li]

Thank you very much @ClaudiuGeorgiu .
I just created a python3 branch. Please pull your code to that branch.

[anant-joshi]

Hi, I would also like to help with this. Is there anything left to do in this?

[ClaudiuGeorgiu]

Hi @anant-joshi, I just added basic Python3 compatibility (see the python3 branch). Currently I'm working on the following things:

• use logger.something instead of print (so that all the code is consistent)
• use .format(...) instead of % in strings
• fix typos and update docstrings (this has nothing to do directly with Python3)

Let me know if you want to help with this.

@ylimit, what do you think about this list of tasks?

[anant-joshi]

Sure, sounds good.

[anant-joshi]

I've converted all strings from % to .format().
Here: 1ff2a4e

[Erick2206]

Hey @ClaudiuGeorgiu can I work on porting print statements to loggers?

[ClaudiuGeorgiu]

@Erick2206 yes, of course.

[Erick2206]

@ClaudiuGeorgiu so I have to port all print statements to logger statements, right?

[ClaudiuGeorgiu]

@Erick2206 yes. For example if you find a print statement inside an except block you can convert it to logger.error(...) or logger.warning(...), depending on the severity of the error.

[Erick2206]

@ClaudiuGeorgiu I have sent a pull request, please review it and merge if correct.

[ClaudiuGeorgiu]

@Erick2206 I reviewed the pull request. However I can't merge pull requests, you will have to wait for someone with write access to the repository.

[Jayd-1234]

Hi @ClaudiuGeorgiu , I would like to contribute to towards the porting process. How can I help?

[ClaudiuGeorgiu]

Thanks @Jayd-1234 but at the moment I don't know what else has to be ported to Python3, but if you have any idea just open a new pull request.

[yuanchun-li]

The master branch now supports Python 3. Not well-tested though.

[YurieCo]

Sorry, I haven't saw the branch for Python3