ES Module support

[hookyns]

ES Module support

[Hookyns]

You can create a PR with small change here:

tst-reflect/transformer/src/config.ts

Lines 220 to 229 in 53b56ac

	function isESMModule(options: ts.CompilerOptions) {
	// ref: https://www.typescriptlang.org/tsconfig#module
	const target = options.target || ScriptTarget.ES3;
	const module = options.module || (
	[ScriptTarget.ES3, ScriptTarget.ES5].includes(target) ? ModuleKind.CommonJS : ModuleKind.ES2015
	);
	return [ModuleKind.ES2015, ModuleKind.ES2020, ModuleKind.ES2022, ModuleKind.ESNext].includes(module);
	}

Add the new module kind to line 228.

[Hookyns]

Published in [email protected].
TY for the PR.

[avin-kavish]

Hmm, looks like it's still happening, https://stackblitz.com/edit/tst-reflect-issue-49-kdukpz

Get ctor is generated properly, but it adds this

const _ßr = require("tst-reflect");

[Hookyns]

Should be fixed in [email protected] and [email protected].

Also there was some trouble with typelib mode in nodenext module, cuz of code related to ts-node. Hope it'll be okay.

[avin-kavish]

With ts-node. Not aware of any issues, i know it won't accept .ts extension though. Even .ts files have to be imported with .js.

[avin-kavish]

There's a require statement inserted in meta-writer/type-lib/TypeLibMetadataNodeGenerator.ts and
meta-writer/inline/InlineMetadataNodeGenerator.ts

factory.createIdentifier("require"),

I think that's why.

[Hookyns]

There are some other places where are the requires generated, without using the isESMModule function.

But now I don't know if we modified the isESMModule correctly. It's not just the "module" option but combination with "moduleResolution" or package.json setting. I need to look into it a little bit.

[avin-kavish]

yeah, you might be right. I was asking about top-level await in the typescript repo and they pointed me to this.

https://www.typescriptlang.org/tsconfig#moduleResolution

It has to be set to nodenext apparently.

[avin-kavish]

import { ExpressionKind, } from 'tst-expression';
         ^^^^^^^^^^^^^^
SyntaxError: Named export 'ExpressionKind' not found. The requested module 'tst-expression' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'tst-expression';
const { ExpressionKind, } = pkg;

Can you add a esm export to the packages?

[avin-kavish]

Oh look's like there is one issue. In es mode, imports have to use .js extension for relative imports. getCtor() will have to change. Currently, it's like import("./index")

[Hookyns]

@avin-kavish Do you test it with ttsc or ts-node?

I found some note - from another contributor solving issues for ts-node - saying that ts-node has some issues with extensions .js/.ts so we removed the extensions cuz of it. But it was before nodenext option. They have to fixed it cuz of nodenext IMHO.

[Hookyns]

Try [email protected], [email protected]

[avin-kavish]

woot! works now.

[avin-kavish]

hmm... got another undefined getCtor() case

[Hookyns]

I'm working on it. 👍