Giter Site home page Giter Site logo

Comments (4)

avin-kavish avatar avin-kavish commented on June 1, 2024 1

Alias kind should work for my use case but if you want to keep original typescript behaviour, even a way to check the "deep equality" of the type could work. I'm not really interested in name of the type but it's just knowing that they are exactly equal, (not structurally). Side-effect of fullname not being there is is comparison doesn't work.

In containers, then equality would have to be checked recursively descending into the types property. And by equality I mean, exact class is used. (even though ts considers classes structurally assignable, instanceof checks fail). And there would have to be a similar rule set for other types.

P.S. when doing Alias there will be a generic case to consider. eg, my type above type ManagedReference<Other>

from tst-reflect.

avin-kavish avatar avin-kavish commented on June 1, 2024

I'm getting some inconsistent behaviours with how it handles container types. For example, using the above type,

class Foo {}

type ManagedReference<Other> = Other & Ref<any, Other> 
type X = ManagedReference<any> // resolves to any
type Y = ManagedReference<unknown> // resolves to Ref<any, unknown> 
type Z = ManagedReference<Foo> // resolves to intersection with Foo & Ref<any, Foo> 
type V = ManagedReference<Foo | null> // same type as above but empty name & fullName, I think this is a bug

When it resolved to any, it's not visible whether a container was used. I think we should be capturing the type the user has used, not the final simplified type.

from tst-reflect.

Hookyns avatar Hookyns commented on June 1, 2024

That simplification is what TypeScript does, that's how the type aliases works. It's just "virtual" placeholder; it's not a real type. Type alias is direct type reference or alias/placeholder for some unions and/or intersections. That's why container types should not have name nor fullName, never. U should not try to compare containers directly IMHO. You can end up with one container which will be union of two other containers eg. intersections. type A = (B & C) | (D & E) Maybe the top level container will have a name, but those inner containers will not, they have no name, because they are not aliased.

Eg. type T = any & Ref<any, any>.
I'm able to get information about that alias by reading its declaration (traversing the AST) but that's complicated. I would have to handle all possible declarations. That's why Record, Omit etc. were not working for a long time. I removed manual reading and now I just ask TS what type it is.

But I can change a behavior around types a little. I can introduce new kind Alias. It will have name and fullName but it will still resolve into final simplified type. It will be like Container kind but you will know that it is specific type alias with name and fullName.

from tst-reflect.

Hookyns avatar Hookyns commented on June 1, 2024

Fixed in v1. Not in the current version.

from tst-reflect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.