Comments (2)
From the code, I see that the listener is weak referenced. Since we set the listener at onCreate() and the dialog only pops up when we close the app, it is likely that OnClickButtonListener
object is garbage collected since there is no strong reference to this object. If the object is gone, the callback won't happen.
I think the weak reference is used mainly with the assumption that the activity itself is the listener. So the work around is to make activity implement OnClickButtonListener
interface and set listener like this: .setOnClickButtonListener(this)
I confirm if Activity itself implements OnClickButton
interface, the callback works correctly. But this shall be fixed if my above understanding is correct. It is very common to create listeners inline in java.
from android-rate.
Hi @rpattabi ,
Fixed in https://github.com/Vorlonsoft/AndroidRate since Release 1.2.1
from android-rate.
Related Issues (20)
- Add the method so that developers can control their own jump market HOT 1
- If the user was gave a rating after that no need to show the dialog after certain period .permanently disable that.How we can handle this? HOT 3
- A memory leak occurs when the screen rotates HOT 2
- dialog window custom color and buttons colors HOT 5
- Against dialog guidelines HOT 1
- App has stoped HOT 7
- shows error page when user presses on RateNow HOT 4
- If setRemindInterval is set to 25 or more, the number of days is not set correctly HOT 2
- On Click Rate Us Button Playstore Item not Found HOT 2
- Should the app be in full production so that the rating library works?
- issue with wait(long millis) HOT 2
- How to check that a user has already rated? HOT 1
- Where and how do i need to put link to my app in appStore? HOT 1
- Integrate Android-Rate with ReviewManagerFactory
- App Rate dialog should be able to adjust text colors
- Setting a custom view doesn't remove default
- Need More App Store URLs
- Huawei ( appGallery ) not supported
- Rat
- Set random install days
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-rate.