Comments (9)
I think that'd be entirely possible. I'll reopen this and adjust the title to track the work
from origami.
Crap. It's my bad. My bower_components
folder was in a wrong directory. I spent the entire day trying to figure this out. Finally figured it out by looking at the angular-polymer-starter-kit
.
from origami.
Verified the patch script works in my starter kit and published in v2.0.2!
I do kind of like having bower_components/
in the project root next to node_modules/
, it's a much more familiar place coming from Polymer.
from origami.
Can you try running the patch cli script? Sounds like the webpack loader isn't added to Angular.
node node_modules/@codebakery/origami/patch-cli.js
from origami.
Does the readme need to be more clear about why the bower folder needs to be in a certain directory? I only instruct the developer to do so in https://github.com/hotforfeature/origami#2-use-bower-to-add-elements without a real reason.
Alternatively, did you have your bower folder in the default root directory? I may be able to modify the patch script to support either the root folder or the src folder.
from origami.
I'm setting it up on a Laravel application so I actually put the bower inside the public folder, which is how Polymer does it. Maybe you could specifically mention that part. I didn't actually catch the "app's root" part specified in the readme, I just assumed its the usual public folder.
But the way you have done is more preferable to me, because I'd like the vendor codes to be outside of public folder.
FYI: I'm creating a boilerplate with Laravel+Angular+Polymer.
from origami.
I looked at the Angular CLI code, and it does look like there is a variable exposed for both the app's root and the project's root directory. I can easily modify the patch script to include both when webpack is searching for bower modules.
from origami.
Would it be possible to get the bower folder straight from the .bowerrc file?
from origami.
Hm, almost verified. I need to add documentation about why bower_components/
should be in the app's folder somewhere if the app root isn't the same as the project root. It's needed if you refer to the components in the index.html
, which I recommend for the webcomponents loader.
from origami.
Related Issues (20)
- Support for embedded media in Polymer elements ? HOT 2
- Unit Tests HOT 3
- Any way to run this with Angular 6? HOT 5
- Instead of `path-cli`, couldn't we use `ng eject` istead? HOT 4
- Docs: Zone.js doesn't play nice with webcomponents HOT 3
- How to use two-way databinding with vaadin-grid-filter for vaadin-grid? HOT 7
- Polyfill utilities throws "TypeError: Cannot read property 'toLowerCase' of undefined" HOT 7
- Dynamic/defer importing the AppModule makes the app failed to compile HOT 4
- IncludeStylesModule expects RouterModule to be imported. HOT 3
- Update for Angular 7 support HOT 5
- @IncludeStyles does not work on non-root component HOT 13
- Latest version 3.1.1 causes ERROR ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor HOT 4
- routerLink within <template> HOT 1
- Origami prepare command throwing error with Polymer v3.3.1 HOT 2
- Angular 9 and ivy HOT 2
- Failed to compile entry-point @codebakery/origami/styles (module as esm5) due to compilation errors HOT 2
- paper-input-container attach causes "Cannot read property 'addEventListener' of null" HOT 1
- Angular 13 @angular/common Could not resolve dependency HOT 3
- Cannot read property 'polyfillWrapFlushCallback' of undefined
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from origami.