Update installation README

[hotwired]

Update installation README

[afomera]

This is fixed in the main branch from GitHub, it was due to a missing index.js file in the controllers folder, and the application.js calling import "controllers" after running the install script. This is the PR where the error was fixed: #34

a comment here #40 references that webpacker:install:stimulus is going to be removed (I guess it's gone in the 6.0 betas for webpack already).

[noctivityinc]

I did a clean install today of the master branch and until I ran rails webpacker:install:stimulus which I got from that comment, it would not work.

…

On Wed, Feb 3, 2021 at 10:26 PM Andrea Fomera ***@***.***> wrote: This is fixed in the main branch from GitHub, it was due to a missing index.js file in the controllers folder, and the application.js calling import "controllers" after running the install script. This is the PR where the error was fixed: #34 <#34> a comment here #40 <#40> references that webpacker:install:stimulus is going to be removed (I guess it's gone in the 6.0 betas for webpack already). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#43 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAATIARNJNYAMA664DLFRRTS5IHXXANCNFSM4XA7RHPA> .

[afomera]

I just ran it again on a fresh app too, and don't run into any problem. Can you post what the rails stimulus:install script outputs by chance?

Also double check that the gemfile has gem 'stimulus-rails', github: 'hotwired/stimulus-rails', branch: 'main' and you've bundled/restarted?

I got this output:

± rails stimulus:install
Appending Stimulus setup code to /Users/afomera/Projects/stimulus-test/app/javascript/packs/application.js
      append  app/javascript/packs/application.js
Creating controllers directory
      create  app/javascript/controllers
      create  app/javascript/controllers/hello_controller.js
      create  app/javascript/controllers/index.js
Installing all Stimulus dependencies
         run  yarn add stimulus from "."
yarn add v1.22.10
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning " > [email protected]" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning "webpack-dev-server > [email protected]" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
[4/4] 🔨  Building fresh packages...
success Saved lockfile.
success Saved 5 new dependencies.
info Direct dependencies
└─ [email protected]
info All dependencies
├─ @stimulus/[email protected]
├─ @stimulus/[email protected]
├─ @stimulus/[email protected]
├─ @stimulus/[email protected]
└─ [email protected]
✨  Done in 4.43s.

Can follow the commits from a initial rails new here: https://github.com/afomera/trying-stimulus-rails/commits/main

I guess the last question if that all fails is what doesn't work? Unable to compile webpack? What kind of error do you see?

[noctivityinc]

Well right now it works (except for the double load) but I’ll switch to that direct branch and see if it still does and maybe solves the other issue. Best, Josh

…

On Thu, Feb 4, 2021 at 12:26 AM Andrea Fomera ***@***.***> wrote: I just ran it again on a fresh app too, and don't run into any problem. Can you post what the rails stimulus:install script outputs by chance? Also double check that the gemfile has gem 'stimulus-rails', github: 'hotwired/stimulus-rails', branch: 'main' and you've bundled/restarted? I got this output: ± rails stimulus:install Appending Stimulus setup code to /Users/afomera/Projects/stimulus-test/app/javascript/packs/application.js append app/javascript/packs/application.js Creating controllers directory create app/javascript/controllers create app/javascript/controllers/hello_controller.js create app/javascript/controllers/index.js Installing all Stimulus dependencies run yarn add stimulus from "." yarn add v1.22.10 [1/4] 🔍 Resolving packages... [2/4] 🚚 Fetching packages... [3/4] 🔗 Linking dependencies... warning " > ***@***.***" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0". warning "webpack-dev-server > ***@***.***" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0". [4/4] 🔨 Building fresh packages... success Saved lockfile. success Saved 5 new dependencies. info Direct dependencies └─ ***@***.*** info All dependencies ├─ @***@***.*** ├─ @***@***.*** ├─ @***@***.*** ├─ @***@***.*** └─ ***@***.*** ✨ Done in 4.43s. Can follow the commits from a initial rails new here: https://github.com/afomera/trying-stimulus-rails/commits/main I guess the last question if that all fails is *what* doesn't work? Unable to compile webpack? What kind of error do you see? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#43 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAATIATW2YH5K7Z2WK2UDFDS5IVZTANCNFSM4XA7RHPA> .

[dixpac]

@noctivityinc , @dhh published latest 0.2.3 with the fix yesterday .
So I think we can close this one 😄