Giter Site home page Giter Site logo

Comments (5)

dhh avatar dhh commented on July 28, 2024

The import-mapped approach to this is to use the autoloader. You shouldn't be using the manifest:update with import maps. We should document this / maybe even short-circuit the command if you try.

from stimulus-rails.

ianneub avatar ianneub commented on July 28, 2024

The import-mapped approach to this is to use the autoloader. You shouldn't be using the manifest:update with import maps. We should document this / maybe even short-circuit the command if you try.

Ah I see, thank you. It looks like my issue is because of:
https://github.com/hotwired/stimulus-rails/blob/main/lib/generators/stimulus/stimulus_generator.rb#L9

I have a package.json file for generating CSS. I'm not using it for the Javascript side though.

from stimulus-rails.

dhh avatar dhh commented on July 28, 2024

That's a good catch. Perhaps we should flip this detection such that it looks for the presence of config/importmap.rb instead of looking for package.json!

from stimulus-rails.

ianneub avatar ianneub commented on July 28, 2024

Maybe something like #89 @dhh ? I can take a stab at the README as well before merging.

from stimulus-rails.

ianneub avatar ianneub commented on July 28, 2024

Looking at the README, it may not be necessary to explicitly mention that the stimulus:manifest:update task is not needed. Speaking for myself, I probably wouldn't have tried to use the command if the generated file hadn't mentioned it.

from stimulus-rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.