Using action option changes the order of actions

[janko]

Using action option changes the order of actions

[adrienpoly]

Thanks @janko for this detailed report. I think this PR #684 might fix it.

The PR mentions action added dynamically so it is not exactly the same. I ll see if I can create a test reproducing your but and run it against that PR.

[adrienpoly]

I ran some additional test

given this original test from the test suite:

async "test adding an action to the left"() {
    this.actionValue = "c#log3 c#log d#log2"
    await this.nextFrame
    await this.triggerEvent(this.buttonElement, "click")

    this.assertActions(
      { name: "log3", identifier: "c", eventType: "click", currentTarget: this.buttonElement },
      { name: "log", identifier: "c", eventType: "click", currentTarget: this.buttonElement },
      { name: "log2", identifier: "d", eventType: "click", currentTarget: this.buttonElement },
      { name: "log", identifier: "c", eventType: "click", currentTarget: this.element }
    )
  }

I modified it to add a :prevent modifer

async "test adding an action to the left with a :prevent modifier"() {
    this.actionValue = "c#log3:prevent c#log d#log2"
    await this.nextFrame
    await this.triggerEvent(this.buttonElement, "click")

    console.log(this.actionLog.map(({ name }) => name))
    this.assertActions(
      { name: "log3", identifier: "c", eventType: "click", currentTarget: this.buttonElement },
      { name: "log", identifier: "c", eventType: "click", currentTarget: this.buttonElement },
      { name: "log2", identifier: "d", eventType: "click", currentTarget: this.buttonElement },
      { name: "log", identifier: "c", eventType: "click", currentTarget: this.element }
    )
  }

The test fails events are received in this order
['log', 'log2', 'log3', 'log']
whereas it should be
['log3', 'log', 'log2', 'log']

Running the same test with #684 works. I'll what we can do to get this PR merged. While it is not a complete solution think it solves the vast majority of this issue