Comments (4)
As discussed in #1101 the Sec-
prefixed headers are intentionally not allowed to be set via fetch(..)
:
In the Fetch Standard under the "Forbidden Header Name" section, the following paragraph explicitly mentions that any header starting with Sec-
should not be allowed to be set by client (eg. via JS), but rather be fully controlled by the user agent:
A header (name, value) is forbidden request-header if these steps return true:
...
- If name when byte-lowercased starts with
proxy-
orsec-
, then return true.
The linked spec also mentions why these are reserved, even in the future:
Note: These are forbidden so the user agent remains in full control over them.
Header names starting withSec-
are reserved to allow new headers to be minted that are safe from APIs using fetch that allow control over headers by developers, such as XMLHttpRequest. [XHR]
The current implementation in Turbo 8 is a no-op.
from turbo.
Fixed in #1108
We're now using X-Sec-Purpose
instead.
from turbo.
It would be great to have this addressed. Could you guys please have a look?
Ping @rik @hey-leon @seanpdoyle @davidalejandroaguilar @afcapel
from turbo.
Hey @psyipm I am not part of any team on the Turbo repository but I did read the PR body and elaborating comment and it seems pretty clear cut to me. If its explicitly called out that Sec-*
is not allowed in the whatwg specifications for fetch it would make sense to change it π.
from turbo.
Related Issues (20)
- v8.0.0-beta1 - "could not be built" error when loading
- Publish beta packages using `--tag="beta"`
- data-turbo-confirm on form does not work when action includes extension HOT 3
- Links don't work with target="_self"
- Turbo frame breaking
- Very new to turbo --- log filling with hundreds of stream HOT 1
- `turbo-visit-control` isn't respected with morphing HOT 1
- Symfony UX Turbo : The response (500) did not contain the expected <turbo-frame id="message_form"> and will be ignored
- Page refreshes: Selected option issue when morphing with changing select options HOT 4
- Support alias for data-confirm / data-disable-with
- Turbo Drive redirect doesnβt send cookies HOT 3
- Turbo Progress Bar Delay not work after opening a 404 Page
- Turbo Frame reload - no morphing possible? HOT 3
- issue adding new content to the top of the page
- How to prevent FOUC when HTML is loaded before the styles? HOT 2
- Turbo Preloads should not be prevented when using the closest Turbo Frame HOT 1
- Turbo stream links proper handling when users middle click, open new window, CTRL click on links HOT 2
- 8.0.0-beta.3 - Issue with stylesheets HOT 2
- Trix editor breaks after page morph HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from turbo.