Giter Site home page Giter Site logo

Comments (4)

pfeiffer avatar pfeiffer commented on August 16, 2024 2

As discussed in #1101 the Sec- prefixed headers are intentionally not allowed to be set via fetch(..):

In the Fetch Standard under the "Forbidden Header Name" section, the following paragraph explicitly mentions that any header starting with Sec- should not be allowed to be set by client (eg. via JS), but rather be fully controlled by the user agent:

A header (name, value) is forbidden request-header if these steps return true:
...

The linked spec also mentions why these are reserved, even in the future:

Note: These are forbidden so the user agent remains in full control over them.
Header names starting with Sec- are reserved to allow new headers to be minted that are safe from APIs using fetch that allow control over headers by developers, such as XMLHttpRequest. [XHR]

The current implementation in Turbo 8 is a no-op.

Ping @davidalejandroaguilar

from turbo.

afcapel avatar afcapel commented on August 16, 2024 1

Fixed in #1108

We're now using X-Sec-Purpose instead.

from turbo.

psyipm avatar psyipm commented on August 16, 2024

It would be great to have this addressed. Could you guys please have a look?

Ping @rik @hey-leon @seanpdoyle @davidalejandroaguilar @afcapel

from turbo.

hey-leon avatar hey-leon commented on August 16, 2024

Hey @psyipm I am not part of any team on the Turbo repository but I did read the PR body and elaborating comment and it seems pretty clear cut to me. If its explicitly called out that Sec-* is not allowed in the whatwg specifications for fetch it would make sense to change it πŸ‘.

from turbo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.