Feature request: survive reinitialization

[hoyon]

Feature request: survive reinitialization

[duxks2]

This seems to also cause any use of the --loop-file=N option to segfault (--loop-file=0 and inf keep working), e.g. mpv --loop-file=2 /dev/null:

Thread 11 "mpv/SO plugin (" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffd2ffd700 (LWP 75101)]
0x00007fffe82b7616 in event_handler () from /home/mod/.config/mpv/scripts/mpris.so
(gdb) bt
#0  0x00007fffe82b7616 in event_handler () at /home/mod/.config/mpv/scripts/mpris.so
#1  0x00007ffff52d726f in g_main_context_dispatch () at /usr/lib/libglib-2.0.so.0
#2  0x00007ffff52d91b1 in  () at /usr/lib/libglib-2.0.so.0
#3  0x00007ffff52da0c3 in g_main_loop_run () at /usr/lib/libglib-2.0.so.0
#4  0x00007fffe82b8380 in mpv_open_cplugin () at /home/mod/.config/mpv/scripts/mpris.so
#5  0x00005555556204c3 in  ()
#6  0x000055555562036b in  ()
#7  0x00007ffff65b146f in start_thread () at /usr/lib/libpthread.so.0
#8  0x00007ffff54bc3d3 in clone () at /usr/lib/libc.so.6

[hoyon]

Thanks for the bug report! Thankfully the issue wasn't as bad as I thought and was just simply a case of properly cleaning up the glib callbacks and dbus objects before shutdown. I hadn't considered the possibility of reinitialising mpv so didn't feel it necessary to properly clean up everything.

Let me know if it works properly with your application.

[hoyon]

(@duxks2 I can't seem to repro your issue. Running mpv --loop-file=2 /dev/null gives an mpv error and running mpv --loop-file=2 /some/file.mp3 seems to work. Feel free to create another issue if needed.)

[Aanok]

Indeed, everything seems to be working fine now. Thank you for the quick fix! :)