Magic Numbers testing [15]

[hpi-swa-teaching]

Magic Numbers testing [15]

[bdaase]

A first idea for a Regex matching magc numbers could look like as follows:

(?<=[\W])(?<![[A-Za-z_])\d+(?![]])(?=[\W])

The idea was mentioned here https://stackoverflow.com/questions/26246260/regex-to-find-magic-numbers-excluding-comments-for-code-written-in-c

[tom95]

As a first test, we will reformulate the magic number test to return all numbers that are found in the code that don't match the following criteria:

• found in a method that only returns a single number literal
• found in an assignment to a single number literal
• number 1, 0, or -1

[bdaase]

At the moment (Commit f84ec08) it works as follows:
Every number that is not a 0,1 or -1 which which does not appear in a return statement will be treated as a magic number. That might still be to hard, but looks like a valid first implementation.