Error with CLI `tokenize` using `click==8.1.3`

[gsarti]

Error with CLI `tokenize` using `click==8.1.3`

[alvations]

Thank you for reporting the bug! Changed the code accordingly to fit click 8.0 name change in the call back.

pip install -U sacremoses>=0.50

Should work with latest click now.

[eddie-scio]

Just noting that wandb avoids click 8.0.0 which makes it incompat: https://github.com/wandb/client/blob/master/requirements.txt#L1

[alecbrick]

can we do <8.1?

[alvations]

Ah tricky let me see if I can work out something.

[alvations]

I've fixed the click dependency to 7.1.2. last version before 8.x (for now) but maybe if this click dependency gets a little too pesky and I'll replace it in the long run.

pip install -U sacremoses>=0.51

Hope it works for everyone now.

[alecbrick]

i mean, i think the issue here is that when the code was originally resultcallback, click wasn't restricted to <8.0.0 - regardless of any changes that are made now, the old version will still have this issue

i think it's perfectly fine to set click>=8.0.0 and use result_callback, and anyone experiencing this issue needs to either bump sacremoses or restrict click themselves

up to you in the end, though

[alvations]

In the long run, seems like getting rid of click is the way to go.

Meanwhile I think there's no need to fixed click version to anything. It's a simple name-change difference of the callback function that makes click non back-compatible.

Let me think of something to monkey-patch just that callback function names.

[alvations]

I've uploaded a version that supports both click versions 7.x and 8.x.

pip install -U sacremoses>=0.53

IMHO, it's a nasty fix so I'll think hard on how to remove click.

[alvations]

Let me know if anyone using either version of clicks fails on your end.

[gsarti]

Looks good, thanks!