Comments (11)
I think it's great! Thank you so much
from verdata.
I think that this is a great idea! You should organize the data into a spreadsheet, but then we'll probably want to save it as an RData
file and then store it in folder called data
. We'll then need to make sure it's exported properly, etc. I'd recommend starting with the panorama documents and then maybe moving to some of the other reports we worked on internally.
The pinochet
package provides a relevant example of how this is done.
from verdata.
Great! I'll work on this. Thanks!
from verdata.
Hi @thegargiulian I have created the data
folder and stored there the list of stratifications both in English and Spanish, with information on how to transform variables according to our estimates. Could you take a look at it and tell me if they have the right format?
Thanks!
from verdata.
Maybe we should also explain what the data
folder contains in the ReadMe?
from verdata.
Hi @mduranf, I just had a chance to look over the stratification files and they look great!
Just a couple of suggestions:
- make the column names in both files all lowercase
- Change the files from
.RDS
files to.rda
files as.RDS
files are causing adevtools::check()
warning (see here, looks likeusethis::use_data()
will facilitate this operation) - Change "Indicaciones" to "notas" and "Indications" to "notes"
- Update the GitHub links once we do the examples repository rename
- Maybe the files can just be named
estratificacion
andstratification
or something like that without the ES/EN distinction
And yes, we should definitely explain these files in the README in the estimation section, with or right after discussing estimates_exist
!
from verdata.
Thanks @thegargiulian! I've made this changes to the files. I updated the links assuming the new name would be verdata-examples, but I can't change the name of the repository, maybe you can?
from verdata.
I just renamed the repository! You'll just need to reclone the repository on your local machine in order to keep working on it (cc: @pamadoa)
from verdata.
I just looked at the updated files and they look good to me The only other thing we need to do is write short documentation files for the two data files: https://r-pkgs.org/data.html#sec-documenting-data
@mduranf, let me know if you'd like me to work on this!
from verdata.
Following up on our conversation from this afternoon, I'll prepare the documentation for the two stratification data objects
from verdata.
Hi @mduranf, I've created the documentation for these two data frames. Can you take a quick look at the Spanish version and let me know if there's anything you'd like me to change (it's very short): https://github.com/HRDAG/verdata/blob/main/R/estratificacion.R
Thanks!
from verdata.
Related Issues (20)
- Review test warnings
- README contains unnecessary instructions
- Make data dictionary available as data frame in package
- Add plain text license
- Provide guidance on how to download data HOT 1
- Tests are not replicable HOT 4
- Improve title for combine_estimates
- Provide alternate Rd title for `get_valid_sources()` HOT 1
- Fix documentation for estimates_exist
- Fix documentation titles
- Move part of package description to README
- Installation instructions: Check if `devtools` is installed
- Provide examples as vignettes HOT 1
- Provide contribution instructions
- Set up continuous integration HOT 4
- Function to automatically download data from DANE website
- [Doc] add example for estimates_exist()
- Updates to DESCRIPTION file
- replace `\dontrun` with `\donttest`
- Remove `options(warn=-1)`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from verdata.