Giter Site home page Giter Site logo

Comments (3)

sothawo avatar sothawo commented on June 6, 2024

Wow, that was fast.
I just wanted to create a PR and was looking for issue and found it closed ;-)

My change would have been:

private fun JsonReader.responseElements() =
    obj({ it -> ResponseElementsEntity(it["xAmzId2"] as? String, it["xAmzRequestId"] as? String) }) {
        when (it) {
            "xAmzId2", "x-amz-id-2" -> nextString()
            "xAmzRequestId", "x-amz-request-id" -> nextString()
            else -> error("unknown key")
        }
    }

to keep the possibility of both spellings (you never know what AWS really wants).

But thanks for that fast response and fix.

from http4k.

daviddenton avatar daviddenton commented on June 6, 2024

no worries. The offical docs list the - cased version - it was an oversight of ours when creating the module in the first place. If it still turns out to be a problem we can update again.

from http4k.

daviddenton avatar daviddenton commented on June 6, 2024

Releasing this in a few minutes :)

from http4k.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.