Giter Site home page Giter Site logo

Comments (6)

rviscomi avatar rviscomi commented on May 19, 2024

@AymenLoukil let me know if you have any questions about the implementation of this feature. Have you tried running the local development environment as a first step?

from almanac.httparchive.org.

AymenLoukil avatar AymenLoukil commented on May 19, 2024

@rviscomi not yet, i'll try to do it today or tomorrow.

from almanac.httparchive.org.

AymenLoukil avatar AymenLoukil commented on May 19, 2024

@rviscomi the local environment is set up and running :)
First thing i remarked (not only about hreflang) :

  • html lang should have en or ja only without any country code. We are targeting people speaking languages wherever they are
  • Language code for Japaneese is ja and not jp
  • / and /en/ should not have the same content. The "english" home page will be / or /en/ ? One should redirect to the other.

Regarding the hreflang implementation, should we do it static or dynamic to ensure the mapping is ok (bidirectional hreflang, in case of new translations added etc ?).
Who will develop the feature ?

from almanac.httparchive.org.

rviscomi avatar rviscomi commented on May 19, 2024

html lang should have en or ja only without any country code. We are targeting people speaking languages wherever they are

Sounds good. In #69 I've added Language objects that have all of the info you need, including both language codes and localized language codes.

Language code for Japaneese is ja and not jp

Yes, you're right. Is there anywhere that we have it wrong?

/ and /en/ should not have the same content. The "english" home page will be / or /en/ ? One should redirect to the other.

Oh interesting, this is something we've considered before but not for SEO. It would actually simplify the site a lot if we always serve content from the language-specific subdirectories. I'll make a new issue for this.

Regarding the hreflang implementation, should we do it static or dynamic to ensure the mapping is ok (bidirectional hreflang, in case of new translations added etc ?).

Should be dynamic. In 2019 we will support at least Japanese, Russian, and Spanish, but in future editions we might not have the same support. So it would be great if the template logic can build the hreflangs only for that year's supported languages.

Who will develop the feature ?

You? :)

from almanac.httparchive.org.

AymenLoukil avatar AymenLoukil commented on May 19, 2024

Hmm, i've never developed in Flask but i could try.. it should be fun :)

from almanac.httparchive.org.

AymenLoukil avatar AymenLoukil commented on May 19, 2024

PL #74

from almanac.httparchive.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.