Comments (3)
Yeah I'm not familiar with how the oauth stuff works since I just use an api key.
If you think it would be helpful, we could do that, but maybe just move checking if the client is passed, to the constructor like this?
/**
* @param string|null $apiKey
* @param bool $oauth
* @param HttpClient $client
* @throws HubSpotException
*/
protected function __construct($apiKey = null, $oauth = false, HttpClient $client = null)
{
$this->oauth = $oauth;
$this->apiKey = $apiKey ?: getenv('HUBSPOT_API_KEY');
if (empty($this->apiKey)) {
throw new HubSpotException("You must provide a HubSpot api key.");
}
$this->client = $client ?: new Client;
}
/**
* @param string $access_token HubSpot oauth access token
* @param HttpClient $client An Http Client
* @return static
*/
public static function makeWithToken($access_token, HttpClient $client = null)
{
return new static($access_token, true, $client);
}
/**
* @param string $name
* @param null $arguments
* @return mixed
* @throws HubSpotException
*/
public function __call($name, $arguments = null)
{
$apiClass = $this->getApiClassName($name);
if (! (new \ReflectionClass($apiClass))->isInstantiable()) {
throw new HubSpotException("Target [$apiClass] is not instantiable.");
}
return new $apiClass($this->apiKey, $this->client, $this->oauth);
}
from hubspot-php.
Yeah that makes sense, it means there's only ever one client per HubSpotService too, which is a bit more efficient.
from hubspot-php.
👍
from hubspot-php.
Related Issues (20)
- Release 3.1.0 HOT 2
- Is there a way to get all deals that are marked as 'closed won' that have been last modified within the past 5 days? HOT 1
- Creating Notes with Engagements results in "metadata cannot be null" HOT 1
- Guzzle error HOT 1
- Support quotes API HOT 1
- Sequential page requests causing slow response on get crm()->companies()->getAll() HOT 2
- HubSpot Contacts Search API Broken? HOT 1
- How to create ticket with associate email? HOT 5
- This Repo Is NOT For API Version 3 HOT 1
- new release? HOT 1
- PHP 8.1 deprecations HOT 3
- Support for GDPR DELETE Endpoint HOT 2
- Form submission fails with '400 Bad Request' HOT 2
- Association error. HOT 1
- Error creating or updating contact using old API HOT 1
- Analytics::getType uses wrong parameter names for start and end Dates HOT 1
- New Webhook Signatures HOT 2
- Hubspot Private app token ? HOT 1
- Can you please add note engagement end point ? HOT 1
- Symfony\Component\ErrorHandler\Error\FatalError with latest http-message PSR version HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hubspot-php.