TypeScript definitions

[hubspot]

TypeScript definitions

[jc0n]

+1

[DenisCarriere]

Seems like nothing is being merged in this library. PR #92

[gshackles]

Looks like that should take care of this, thanks! 😄 Any ETA for that making it out into a release?

[DenisCarriere]

@gshackles The definitions is already published to@types/humanize-plus, you can start using it right now 🎉 !

Feel free to send PR's to DT and I can 👍 the changes.

DefinitelyTyped/DefinitelyTyped#16977

https://www.npmjs.com/package/@types/humanize-plus

[gshackles]

Ah awesome. That said, in #92 you added the type definitions directly into this repository, so even better would be to push an updated package out that includes that definition and avoid the need for pulling in the separate definition from DT 😀

[DenisCarriere]

You are correct, however no one merges anything in this library, unless you have admin privileges to merge?

[DenisCarriere]

I opened that PR March 3rd

[gshackles]

Doh, sorry, that's what I get for reading too quickly...I saw the closed PR but missed the fact that it wasn't actually merged. In that case, I suppose the typing will do the trick for now!

[DenisCarriere]

👍 Yea... if you can convince the maintainers of this library to merge or accept a Typescript definition, we can make another PR.

[FranDias]

Hey, someone with admin privileges here—

Internally we merged this with our larger i18n library so it's a bit of a split for us to maintain both. You're more than welcome to fork and maintain & I'm happy to work with whoever wants to get things pointed there.

Also, thanks for taking a look at this and being proactive to supply the solution independent of lack of response.

[gshackles]

Whoops missed this til now. Thanks for the response, @FranDias!

If this isn't really being updated anymore then I think just leaving the separate type package seems reasonable. We don't have a real need to fork/maintain at this point, but if the need arises we can revisit.

Closing this issue out then, thanks all!