Downloading from nodejs.org is blocked by firewall

[hubspot]

Downloading from nodejs.org is blocked by firewall

[mikaello]

Many that have an air gapped environment has the possibility to specify proxies with Nexus/Artifactory for https://nodejs.org/dist and NPM registry, including us. Could you provide these as config variables?

Name	-D property name	Default value	Description
nodeRegistry	prettier.nodeRegistry	https://nodejs.org/dist/	Where to fetch node binary
npmRegistry	prettier.npmRegistry	https://registry.npmjs.org/	Registry used to fetch prettier-plugin-java

[jaredstehler]

Should this config not skip the download of node?

@leonardehrenfried i believe you need to specify both nodePath and npmPath to skip the downloading. see:

prettier-maven-plugin/prettier-maven-plugin/src/main/java/com/hubspot/maven/plugins/prettier/PrettierArgs.java

Lines 97 to 100 in 548539f

	if (maybeNode.isPresent() && maybeNpm.isPresent()) {
	return new NodeInstall(maybeNode.get(), Arrays.asList(maybeNpm.get()));
	} else {
	NodeInstall nodeInstall = downloadNode();

[jhaber]

As of #64 the plugin will download node rather than bundling it. If you want to avoid this download, you can supply a node executable yourself and pass the path to the plugin via the <nodePath> configuration parameter (if you want to just use the version of node on your $PATH you can set <nodePath>node</nodePath>

[leonardehrenfried]

I just had this happen to me even though I set a custom node binary:

[INFO] 
[INFO] --- prettier-maven-plugin:0.19:check (default) @ otp ---
[INFO] Using customized nodePath: node
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:57 min
[INFO] Finished at: 2023-03-24T11:39:10Z
[INFO] ------------------------------------------------------------------------
Error:  Failed to execute goal com.hubspot.maven.plugins:prettier-maven-plugin:0.19:check (default) on project otp: Error downloading node: timeout -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Error: Process completed with exit code 1.

Should this config not skip the download of node?