Assertion error on program exit

[huceke]

Assertion error on program exit

[torarin]

I have seen that assertion error before, but I can't for the life of me reproduce it now. In any case, it's a side effect of the old subtitle code which isn't used anymore, so I guess we should just rip that all out. The assert itself breaks the terminal because omxplayer's termios trickery isn't properly cleaned up.

See if this doesn't fix things: https://github.com/torarin/omxplayer/tree/remove_old

[torarin]

I wonder if @huceke could chime in on the following:

• COMXCoreComponent::Deinitialize() calls FlushAll. Why? Changing state to OMX_StateIdle should already flush buffers.
• COMXCoreComponent::DecoderEmptyBufferDone and COMXCoreComponent::DecoderFillBufferDone don't push their buffers if m_exit == true. Presumably, this causes the assertion above to trigger. Why can't they push on deinitialization?
• In COMXCoreComponent::Deinitialize(), why is the state set to OMX_StateIdle twice, both before and after Free(Input|Output)Buffers?

[ph0ng]

Seems to do the trick!

[ph0ng]

I guess you would need to open a pull request to get @huceke's attention. I've been running this for several days without any problems.

[torarin]

I will, I just wanted to investigate it a bit further.

[popcornmix]

Anyone still seeing this? Can you post a sample file that causes it if you do?