Giter Site home page Giter Site logo

Add option `minimumLines` to ignore `emptyLineBefore` if group has less than specified amount of properties about stylelint-order HOT 3 CLOSED

hudochenkov avatar hudochenkov commented on June 15, 2024
Add option `minimumLines` to ignore `emptyLineBefore` if group has less than specified amount of properties

from stylelint-order.

Comments (3)

hudochenkov avatar hudochenkov commented on June 15, 2024

I'm not sure minimumLines option is viable.

What it should do if there less properties than minimumLines? Ignore emptyLineBefore for this group or revert it?

If emptyLineBefore will be ignored, with a config above this won't be considered as warning:

p {
	position: relative;
	display: block;
	font-family: sans-serif;
}
p {
	position: relative;
	display: block;

	font-family: sans-serif;
}

If emptyLineBefore will be reverted, with a config above this won't be considered as warning:

p {
	position: relative;
	display: block;
	font-family: sans-serif;
}

This will be a warning:

p {
	position: relative;
	display: block;

	font-family: sans-serif;
}

With the following config and if emptyLineBefore will be reverted:

{
	"minimumLines": 2,
	"emptyLineBefore": "never",
	"properties": [
		"position",
		"display"
	]
},
{
	"minimumLines": 2,
	"emptyLineBefore": "never",
	"properties": [
		"font",
		"color"
	]
}

The following patterns are considered warnings:

p {
	position: relative;
	display: block;
	font-family: sans-serif;
}

The following patterns are not considered warnings:

p {
	position: relative;
	display: block;

	font-family: sans-serif;
}

from stylelint-order.

thasmo avatar thasmo commented on June 15, 2024

Maybe it should just be ignored, so it's allowed to skip the empty line but it will be no error with the empty line?

from stylelint-order.

hudochenkov avatar hudochenkov commented on June 15, 2024

Sorry, this feature will never be implemented, because of rare use cases and it will lead to increased code complexity without real benefits.

from stylelint-order.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.