Giter Site home page Giter Site logo

Comments (2)

allenwang28 avatar allenwang28 commented on May 21, 2024

I think we need to add a codepath in Trainer to enable gradient checkpointing for torch_xla using this API

from transformers.

shub-kris avatar shub-kris commented on May 21, 2024

I think we can close this issue as discussed here: pytorch/xla#6611 (comment)

The native grad ckpt won't work in any cases. We need to apply some special treatment for the XLA compiler to make grad ckpt working. Those are implemented here: https://github.com/pytorch/xla/blob/master/torch_xla/utils/checkpoint.py

However, I do think we should able to integrate our grad ckpt into HF such that users don't need to specify xla_fsdp_grad_ckpt in FSDP anymore

from transformers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.