Giter Site home page Giter Site logo

Comments (2)

ydshieh avatar ydshieh commented on May 22, 2024 1

It turns out that it is not me added this modeling file, it's @NielsRogge 😄

https://github.com/huggingface/transformers/pull/13874/files#diff-d6b5547bc8ece59fd6c96645e48cce4f32d0995a6621b57f896ad800168017bd

In such composite modeling cases, the encoder and decoder are usually from 2 different models (well, we could use the same model if it is EncoderDecoderModel), and the input/output tie embedding doesn't really make sense as @amyeroberts mentioned.

You can definitely tweak the code to suit your custom modeling logic and needs.

from transformers.

amyeroberts avatar amyeroberts commented on May 22, 2024

Hi, thanks for raising an issue!

This is a question best placed in our forums. We try to reserve the github issues for feature requests and bug reports.

cc @ydshieh who I believe added this model originally

since the input and output embeddings are from the decoder and the decoder is an XForCausalLM class's object,

I'm not sure this is completely correct - the input to the model are pixel values, and the vision encoder will have its own embeddings, which hare not related to the decoder's embeddings.

from transformers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.