Disable certain docker images from loading in the CI to improve the time required to build the project when running tests

[humanmade]

Disable certain docker images from loading in the CI to improve the time required to build the project when running tests

[johnbillion]

I think this can be closed off as implemented in humanmade/altis-core#487

[roborourke]

@Nikschavan yep, that PR you referenced is required to be able to do this and it's definitely something we want to do.

I've also been considering switching to GitHub actions as a way to provide a test image that has local server pre downloaded.

Regarding your list I don't think Cavalcade should be disabled. Can you elaborate on why you did that? It uses the same container as the PHP one but with different settings so I'm not sure there's any time saving there really in terms of the download, maybe some in start up time.

I'd be reluctant to switch off anything more than the following by default:

• Kibana
• Mailhog
• XRay

Some of the others are dependent on the features you have configured eg. if you don't use S3 you don't need Tachyon, if you don't use search or native analytics you don't need elasticsearch.

I think we should look at adding support for CI environment config overrides specifically to help trim down what containers are spun up in CI.

[Nikschavan]

Regarding your list I don't think Cavalcade should be disabled. Can you elaborate on why you did that? It uses the same container as the PHP one but with different settings so I'm not sure there's any time saving there really in terms of the download, maybe some in start-up time.

I actually did not check how much time an individual image is saving, I am still testing this and I will report back if I have more info on this.

I had disabled cavalcade as I believe it does not need to execute any jobs that get scheduled during the unit tests as they cannot be tested anyway (do correct me if I am wrong and if I am missing something here)

WordPress' test suite disables WP Cron as well, without a fallback cron method - https://github.com/WordPress/wordpress-develop/blob/master/tests/phpunit/includes/bootstrap.php#L85-L89

So my assumption was that disabling the cron will reduce the setup time as well as it "might" reduce the time/resources spent to execute the cron jobs. This is when I am assuming the cron jobs are indeed being executed when the tests are being run.

I am yet to run any tests on how much improvement disabling each image in the list mentioned above is adding, I will report back when I have some more stats on these.