Comments (7)
@luke- Fixed in core PR humhub/humhub#6836
from cfiles.
@yurabakhtin Does this checkbox really executes the core toggle action?
from cfiles.
@luke- This checkbox is visible only when content can be stored as public:
for space with only private content it is hidden:
In the PR humhub/humhub#6836 I have fixed a case when space visibility is updated to Private, but some page with files list was not reloaded yet, so the menu item "Change to Public" is still visible and it was possible update such file to Public, now it is fixed with this way:
Was the bug fixed or I miss something?
from cfiles.
@yurabakhtin Hmm, I think you missed something.
Set "CreatePublicContent" to "Deny" for regular Space Members
Login as "Regular Member".
Upload a "File".
The context menu is correct, the Change to "Public"
option is not available:
When click on "Edit". The option is available:
from cfiles.
@luke- Thanks for the additional info. Fixed in PR humhub/humhub#6837.
from cfiles.
@yurabakhtin Can you please check the failing tests? Maybe also some tests would be great here.
from cfiles.
@luke- The tests have been fixed. I don't think we need additional tests because at least this test testCreatePublicContentOnPrivateSpace does it.
from cfiles.
Related Issues (20)
- Hide files in stream if the related post is on pending deletion HOT 1
- Cosmetic: File listβs columns are moved to the left when the context menu icon appears HOT 1
- Public folders in private spaces HOT 2
- Espace en double
- Possibility to rename/delete own files as space member HOT 13
- File Recycle Bin
- Integrity Check - Memory Usage HOT 2
- Possibility to copy folder/files from one space to another
- Downloading renamed files HOT 1
- Filehandling: Misbehaviour betwenn context menu and dropdown button
- RESOLVED, OTHER CAUSE ENTIRELY - Since the latest update to HumHub 1.15.3 (from 1.15.2), now error any time opening OnlyOffice doc HOT 4
- Error on enabling Modul on new installation HOT 2
- From file guid, how can I know if a file is a "cfile" file ? HOT 1
- Style issue in posts (no margin-right for image "pull-left")
- Wrong post numbering in space stream HOT 1
- Modal Unification - Edit File
- Modal Unification - Edit Folder
- Modal Unification - Move Files
- Text Editor in file Edit - Image insert doen't work properly HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cfiles.