Comments (6)
@swabianeagle good catch, I would accept a pull request from you with this change, if you'd be so kind!
from rubyserial.
Hi Adrian,
sorry for my ignorance as I don't know git very well. What exactly do I have to
do to create a pull request.
Armin
On January 20, 2015 at 2:50 PM Adrian Zankich [email protected]
wrote:@swabianeagle good catch, I would accept a pull request from you with this
change, if you'd be so kind!
Reply to this email directly or view it on GitHub:
#22 (comment)
from rubyserial.
First you'll want to fork this repo, https://help.github.com/articles/fork-a-repo/, and make the appropriate changes in your fork of rubyserial
. Once you have your changes in place, you will see a pull request
button, which is a green square with two arrows pointing towards each other. Hit that button and you're good to go! Here's github's help docs too about pull requests https://help.github.com/articles/using-pull-requests/#initiating-the-pull-request
from rubyserial.
Can you please tag a new release with this fix? It's a fairly serious problem on windows systems. Also, keeping the issue open is sure to cause some confusion, given that the issue is fixed in master (but not in the latest release).
from rubyserial.
Ulp! You are right, let me see if we can fix that today.
from rubyserial.
I just released version 0.2.3 please make sure this corrects your issue, and reopen if not. Thanks!
from rubyserial.
Related Issues (18)
- Disable DTR control signal on connect HOT 4
- Serial#gets("\r") does not work with ruby 1.9.3 and Windows HOT 1
- Windows not correctly handling number of bytes read HOT 3
- Serial doesn't play nice with File on Win8 HOT 5
- Update windows implementation of getbyte to match posix HOT 1
- Add blocking versions of read and write functions HOT 1
- 9-bit support
- How can I send just bytes by rubyserial? HOT 2
- Not able to open Comx on Windows 8.1 HOT 4
- Exception Overkill HOT 2
- Using blocks in gets HOT 1
- flush buffers
- Add support for configuring 2 stop bits HOT 1
- Add support for disabling flow control HOT 1
- Wrong NCCS in linux_constants.rb HOT 4
- Console state is not always updated in case of error during initialization
- ERROR_SEM_TIMEOUT (semaphore timeout) when using with Windows 10 and Ruby from RubyInstaller HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rubyserial.