Giter Site home page Giter Site logo

Comments (6)

zankich avatar zankich commented on July 28, 2024

@swabianeagle good catch, I would accept a pull request from you with this change, if you'd be so kind!

from rubyserial.

swabianeagle avatar swabianeagle commented on July 28, 2024

Hi Adrian,

sorry for my ignorance as I don't know git very well. What exactly do I have to
do to create a pull request.

Armin

On January 20, 2015 at 2:50 PM Adrian Zankich [email protected]
wrote:

@swabianeagle good catch, I would accept a pull request from you with this
change, if you'd be so kind!


Reply to this email directly or view it on GitHub:
#22 (comment)

from rubyserial.

zankich avatar zankich commented on July 28, 2024

First you'll want to fork this repo, https://help.github.com/articles/fork-a-repo/, and make the appropriate changes in your fork of rubyserial. Once you have your changes in place, you will see a pull request button, which is a green square with two arrows pointing towards each other. Hit that button and you're good to go! Here's github's help docs too about pull requests https://help.github.com/articles/using-pull-requests/#initiating-the-pull-request

from rubyserial.

f3rno avatar f3rno commented on July 28, 2024

Can you please tag a new release with this fix? It's a fairly serious problem on windows systems. Also, keeping the issue open is sure to cause some confusion, given that the issue is fixed in master (but not in the latest release).

from rubyserial.

deadprogram avatar deadprogram commented on July 28, 2024

Ulp! You are right, let me see if we can fix that today.

from rubyserial.

deadprogram avatar deadprogram commented on July 28, 2024

I just released version 0.2.3 please make sure this corrects your issue, and reopen if not. Thanks!

from rubyserial.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.