Giter Site home page Giter Site logo

Comments (3)

wrn14897 avatar wrn14897 commented on May 22, 2024 1

Hey @wrn14897,

I've noticed records with no type having the same issue:

Screenshot
Is it safe to assume every event with negative duration doesn't support it and should not be visible?

My first idea was to modify the API response to return null or omit the duration field, instead of a negative number. I'm not so sure anymore, this will require update on the UI anyways, and I don't think having a field that can be of type number and string is great.

I am thinking to have a check at the UI table. If the value is negative - display "N/A" or similar, otherwise - display the amount. Only for the duration field.

Do you think we could do that? Is it okay if I work on it?

This negative number issue is a bit tricky since the 'duration' is a materialized column computed by 'timestamp' and 'end_timestamp' columns. For non log type of lines, the endTime is unix 0 and that's why you see a negative number. I think the right way is to make ingestor send the 'duration' instead of endTime. The quick fix for now is to set the endTime to be startTime if not specified so the duration is 0 (which makes sense for log). I think I can take this ticket and pull up the fix shortly. Really appreciate for the contribution.

from hyperdx.

wrn14897 avatar wrn14897 commented on May 22, 2024

Hey bpartridge,

Thanks for reporting the bug here. This particular line is actually a 'log' not 'span', which means it doesn't have duration. Normally, the span has level 'ok' or 'error'. UI wise, I agree we need to show the type to make it clear.
Since log doesn't have duration, the UI should not display anything in that regard. I'm going to file this ticket and this should be a quick fix. Thanks for the contribution.

from hyperdx.

mark-omarov avatar mark-omarov commented on May 22, 2024

Hey @wrn14897,

I've noticed records with no type having the same issue:

Screenshot Screenshot 2023-09-22 at 18 08 37

Is it safe to assume every event with negative duration doesn't support it and should not be visible?

My first idea was to modify the API response to return null or omit the duration field, instead of a negative number. I'm not so sure anymore, this will require update on the UI anyways, and I don't think having a field that can be of type number and string is great.

I am thinking to have a check at the UI table. If the value is negative - display "N/A" or similar, otherwise - display the amount. Only for the duration field.

Do you think we could do that? Is it okay if I work on it?

from hyperdx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.