Handle malformed messages with continuation frames

[hyperium]

Handle malformed messages with continuation frames

[seanmonstar]

It sounds bad to for our connection to grow inconsistent HPACK state. However, is the proper fix important enough for 0.1, or could we give ourselves time and simply return a connection error for now?

[carllerche]

It isn't an API breaking change, so technically it isn't a 0.1 hard requirement.

That said, I would be surprised if the real fix is much harder than a temporary fix.

[carllerche]

I believe that the solution is to add a new Ignore variant to this. Read the continuation frame & discard it.

And a test of course.

[carllerche]

Digging through, this is a bit more involved, but still not terribly hard. I'll try working on it.

[carllerche]

Looking at this, I discovered another potential issue #191.

[carllerche]

Also, the analysis of the fix is incorrect.

[carllerche]

I'm removing this from the 0.1 milestone. As @seanmonstar pointed out, this is not critical.

[nox]

I believe that the solution is to add a new Ignore variant to this. Read the continuation frame & discard it.

Link with a hash so it doesn't get outdated:

h2/src/codec/framed_read.rs

Lines 46 to 50 in 0457065

	#[derive(Debug)]
	enum Continuable {
	Headers(frame::Headers),
	PushPromise(frame::PushPromise),
	}