Giter Site home page Giter Site logo

Comments (3)

seanmonstar avatar seanmonstar commented on April 28, 2024

Oh right, because it needs to be mutable internally. Maybe Headers could
keep a RefCell of the HashMap. It's mutability is just an implementation
detail, and shouldn't concern users.

That would also improve fighting the borrowck in matches.

from hyper.

reem avatar reem commented on April 28, 2024

RefCell would not be a good solution here as it would be a leaky abstraction and lead to runtime failures when code tries to get two header references with overlapping lifetimes - this code would fail, for instance:

let length = req.headers.get_ref::<ContentLength>();
let encoding = req.headers.get_ref::<TransferEncoding>();

Right now this is a compile-time failure, using RefCell would make it a runtime failure.

We would also have to return cell::Ref and cell::RefMut instead of & and &mut.

from hyper.

reem avatar reem commented on April 28, 2024

Basically scratch the above, I did crazy things with RWLock in #48 that fixes this and more.

from hyper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.