Comments (7)
I've fixed this on master again, sorry for the bugs!
from hyper.
If that gets merged into a rust-url, I'd be happy to use it. Until then, I'll just submit a fix to unblock you (or anyone else) right now.
from hyper.
Awesome! Thanks much.
from hyper.
Also, I thought I'd share the project I'm working on - would love to hear your feedback.
It's a high-level REST API client in Rust, inspired by Ruby's rest-client. I'm going for the smallest amount of code to make the most common types of REST API calls. It depends heavily on Hyper, of course.
https://github.com/gtolle/rest_client
It does work, but it's my first piece of Rust code and there are probably tons of things I could be doing better.
from hyper.
This issue has resurfaced, possibly due to the changes in rust-url 1.0.
serialize_without_fragment is now &url[..Position::AfterQuery]
from hyper.
Yep, I just witnessed the same thing. I'm under the impression that the problem is there:
https://github.com/hyperium/hyper/blob/master/src/client/mod.rs#L303
There is no mention of query anymore (or fragment for that matter). Maybe a simpler way would be to call url.set_host(None) to remove the host and port, and then url.into_string(), so everything else (path, query, fragment) is preserved.
from hyper.
"again" ah I know that feeling... Thanks for fixing this!
from hyper.
Related Issues (20)
- Harden against HTTP Desync attacks HOT 2
- ffi: different input and output types for tasks HOT 2
- Make examples usable (TokioIo) HOT 8
- CHANGELOG doesn't explain what happened to `hyper::Client` or `HttpConnector` HOT 8
- Documentation link in hyper::client::conn for "Higher-level Client API" should probably go to hyper-util now HOT 1
- First byte timeout HOT 1
- From v0.14 to v1 difficulties using Client HOT 1
- hyper-util Client examples are wrong HOT 1
- Upgraded does not impl AsyncRead/AsyncWrite in hyper 1.0 HOT 2
- Can not create hyper::Error HOT 3
- hyper-util missing `max_pending_accept_reset_streams` HOT 1
- There is no way to pass data to the new Server connection service in Hyper 1
- "make_service_fn" - gone. Where is it?
- hyper-util: add `Server::from_tcp`
- Provide public constructur for Incoming - for testing HOT 1
- Re-enable end-to-end request chunks benchmarks HOT 1
- how to retry request by custom policy HOT 1
- v1.0 http2 do not support `with_upgrades()` API HOT 3
- Add CI job checking that the unstable tracing feature compiles
- Suggestion to Include 'Salvo' in Framework Recommendations HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hyper.