New hypre release 2.18.1

[hypre-space]

New hypre release 2.18.1

[rfalgout]

• [MAJOR] Initial documentation review meeting.
• [MAJOR.MINOR] Update user and reference manuals.
• [MAJOR] Final documentation review meeting.
• Update CHANGELOG file with information regarding contents of this release.
• Verify that all agreed-upon changes have been committed.
• Update config/configure.in and CMakeLists.txt with release number and date, then run config/bootstrap and commit changes to the repository.
• Check that the regression tests all run cleanly
  • machine-tux
  • machine-tux-exlibs
  • machine-rztopaz
  • machine-syrah
  • machine-ray
  • machine-vs-pro
• Tag repository with release number: git tag -a v2.18.1 -m "Release v2.18.1" and push the tags to the central repository: git push --tags
• On the CASC cluster, copy the GitHub release tar file to /usr/casc/hypre.
• On the RZ, copy the GitHub tar file to /usr/gapps/hypre (for backup reasons).
• Close the new release GitHub issue.

[bobby-philip]

It looks like the copyright block in

src/HYPREf.h
src/hypre/include/HYPREf.h

tries to use 'c' at the beginning of the line instead of '!' and this causes a compile error. This is for 2.18.0

[rfalgout]

It looks like the copyright block in

src/HYPREf.h
src/hypre/include/HYPREf.h

tries to use 'c' at the beginning of the line instead of '!' and this causes a compile error. This is for 2.18.0

Using 'c' goes way back. Is this really now considered a bug in Fortran 90/95/...? If so, there are a number of other instances in hypre that we will have to fix, not just the headers.

I just did some quick research on this, and it looks like Fortran 77 actually changed the comment character to '*' but accepted 'c' for backward compatibility. Fortran 90 changed it to '!' and I'm not sure what happened to backward compatibility.

I guess we fixed this in 'HYPREf.h' a long time ago (and I just don't remember), because we clearly had the '!' character there before the license change. I'll fix.

[bobby-philip]

Thanks! Intel ifort, 18.0.2 gave this error.

[rfalgout]

@bobby-philip Let me know if my last commit fixes the problem. Thanks!

[rfalgout]

Hi @balay ,

Would you mind running the current master branch through your testing and let us know if all is good before we tag this for release? Let me know. Thanks!

-Rob

[balay]

@rfalgout will check and update

[balay]

I ran a full petsc test pipeline on this snapshot of hypre, and a few xsdk workstation builds [i.e no runs] on linux,osx (gcc,clang,intel) - they all are fine.

[rfalgout]

Thanks, Satish!

[rfalgout]

Hello @hypre-space/developers . If there are no complaints, I will tag the release later this morning.

[bobby-philip]

I checked out the dev version and it built fine against Intel. Thanks!

…

On Mon, Oct 14, 2019 at 5:09 PM Rob Falgout ***@***.***> wrote: @bobby-philip <https://github.com/bobby-philip> Let me know if my last commit fixes the problem. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#55?email_source=notifications&email_token=AB4BZJLG2MSPERU6ASLXNJ3QOT33TA5CNFSM4JAT6K6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBG4RWA#issuecomment-541968600>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4BZJMYCLQHAWEN2OEWEPDQOT33TANCNFSM4JAT6K6A> .

[rfalgout]

Thanks, Bobby!

[rfalgout]

The release is done. Thanks!