Comments (7)
Thanks for your query @Pomax. Hopefully this has not caused anybody any issues - these things do tend to unofficially converge with specced features... innerText
springs to mind as that was eventually standardised!
from react-tags.
I suspect most browsers still support it because it would break all the things if they didn't, but probably worth updating for a next version =)
The .innerText
property is a good example too. but my favourite most recent one I can remember is .outerHTML
which became standardized when no one was looking. It makes life (for some of us) so much easier.
from react-tags.
I tried switching from keyCode
to code
when investigating #84 but unfortunately it doesn't seem to have been implemented in IE nor yet in Edge.
from react-tags.
boo =( (thanks Edge team...)
from react-tags.
The key
seems to be the better attribute, based on: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key .
If we use delimiterChars, then we could do something like:
['Tab', 'Enter', ',']
But that has the risk of causing issues where we really want multi-character delimiters, if there really is a use-case for them.
Whatever solution we come up with, we need to consider:
- Impact on typing, in the
handleKeyDown
method - Impact on pasting, in the
handlePaste
method - Whether there is a need for multi-character delimiters, which don't reference keys.
from react-tags.
I think the separation of delimiter keys (IE. pressing tab or enter) and delimiter characters is OK, so long as it is documented clearly. Using KeyboardEvent.key
definitely seems like a good step to make in the next major version.
from react-tags.
Opened issue #94, based on an issue discovered on Android Chrome, which has an unfortunate impact, when it comes to KeyboardEvent.key and onKeyDown in general.
from react-tags.
Related Issues (20)
- Update @types/react-tag-autocomplete to better support TypeScript HOT 1
- Does not support numeric value if it is brackets HOT 1
- Multiple dynamically created instances, unique tags, shared (unique) suggestions HOT 1
- Option to remove maxSuggestionsLength HOT 2
- suggestion Wrapper component as props
- noSuggestionsText doesn't seem to work in 6.2.0 HOT 2
- In the online demo you can't create a tag with spaces HOT 3
- Typescript Type Definition has handleAddition, handleDelete, ... events while the component has onAddition, onDelete events HOT 2
- In the online demo notifying failure status on creation HOT 1
- How can I get clearInput() from API? HOT 1
- make TagComponent props customizable i.e. enable adding more properties than just id & name. HOT 4
- Autoresize causes input to jump around HOT 3
- Internationalizable newTagText HOT 2
- Label causing first item to be deleted. HOT 1
- suggestion: use React memo on Input, Suggestion and Tags to avoid re render HOT 2
- Support React 18 HOT 3
- Idea - Fix Types - Tag Id can be null ( In case allowNew: true ) HOT 2
- Scroll bar is not moving for suggestions box with keyup and keydown events HOT 4
- Can't Select Suggestion when input cut-off top of screen. (Mi Tab) specific. HOT 8
- Update peer dependency to React so it can be used with latest version HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-tags.