libvdpau-va-gl does not reuse destroyed surfaces

[i-rinat]

libvdpau-va-gl does not reuse destroyed surfaces

[i-rinat]

VDPAU allows the caller to create and destroy surfaces whenever he wishes.

VDPAU documentation says, "The client application is responsible for: <...> Surface management (e.g. H.264 DPB processing, display re-ordering)"

So it should be perfectly valid to create a new surface per each decoded frame and then destroy it when it is no longer needed.

I doubt that. That code does nothing for DPB management, it throws video surfaces away after their usage.

I've implemented formal fix (https://github.com/i-rinat/libvdpau-va-gl/tree/dev), but it does not work correctly, results are garbled. To make this really work, I need to track somehow surfaces that should be in DPB and avoid reusing them until they leave DPB. But that's application task according to VDPAU spec.

[elenril]

I fully agree that managing the DPB must be done by the application. In my case the surfaces should only be destroyed when they are not in the DPB anymore, so I don't yet understand why is the image corrupted.

In any case, thank you for the fix, I'll try to investigate why it doesn't fully fix the problem.

[elenril]

Seems you're just forgetting to set rt_idx on the vdpau surfaces. With commit 4d4b766 from my tree it works perfectly.

[i-rinat]

Seems you're just forgetting to set rt_idx on the vdpau surfaces

Oops. :) Now it works good. Thank you for the fix.

[i-rinat]

You just saved me couple of weeks. I was going to implement own DPB tracking.