Comments (7)
Here is an example patch for such options: https://gist.github.com/Fat-Zer/5845277 .
btw: It would be nice if we could get moduledir from vdpau's pkg-config (like pkg-config vdpau --variable=moduledir), although FindPkgConfig haven't got such features.
from libvdpau-va-gl.
fixed.
from libvdpau-va-gl.
Here is an example patch for such options:
Thanks.
from libvdpau-va-gl.
Sorry for my tedious exhortation, but you supposed to use CACHE variables for such stuff.
Firstly, this three lines:
if(NOT DEFINED LIB_INSTALL_DIR)
set(LIB_INSTALL_DIR ${CMAKE_INSTALL_PREFIX}/lib${LIB_SUFFIX})
endif(NOT DEFINED LIB_INSTALL_DIR)
are equivalent to one:
set(LIB_INSTALL_DIR ${CMAKE_INSTALL_PREFIX}/lib${LIB_SUFFIX} CACHE PATH "<comment>" )
Moreover, the second variant is preferred cause the variable will be prompted in configuration utilities like cmake -I.
Because of that it would be nice to give LIB_SUFFIX it's own declaration as well.
from libvdpau-va-gl.
you supposed to use CACHE variables for such stuff.
Sounds reasonable. Applied.
from libvdpau-va-gl.
LIB_INSTALL_DIR supposed to point to «lib» dir itself, not vdpau.
AFAIK it's not the rule carved in stone but a lot of packages do so and some build systems [e.g. in gentoo] count on it.
from libvdpau-va-gl.
LIB_INSTALL_DIR supposed to point to «lib» dir itself, not vdpau.
IMO, if build system sets custom LIB_INSTALL_DIR, that is the directory where it expects libraries to go. It's much more confusing to figure out that installer decided to append another directory (vdpau) to it. There is no sense to add another configurable variable either. If one have chosen to change LIB_INSTALL_DIR, he may add such suffix himself if needed.
from libvdpau-va-gl.
Related Issues (20)
- cmake issue HOT 5
- Unable to play some video with VLC (hardware accelerator failed to decode picture) HOT 15
- Segmentation fault in dri2_unbind_context HOT 5
- Change license to MIT (expat) HOT 7
- Wrong scaling in fullscreen VLC (was: Problems playing videos in VLC) HOT 24
- Vlc using vdpau, no decoding HOT 6
- Unable to compile HOT 12
- cppcheck errors HOT 3
- Build failure with clang/libc++ on Linux HOT 2
- GPU memory leak in VLC on Intel HOT 4
- Archlinux integration !
- When playing .webm files with video-output default (VDPAU) VLC ends up consuming a lot of RAM (using lib64vdpau-va-gl1-0.4.0-1.mga6 on Intel Graphics) HOT 5
- VLC with "--vout vdpau" won't play the video of a certain .mp4 file (generates an error) HOT 11
- flash video freezes the whole system HOT 3
- VLC's memory consumption steadily increases after switching to next videos HOT 4
- Some videos cause complete system hang with 0.4.0 HOT 7
- Create lists of supported hardware and software. HOT 2
- Discrepancy in decoder capabilities reported by `vainfo` and `vdpauinfo` wrt Kabylake. HOT 1
- vdpauinfo crash with VDPAU_DRIVER=va_gl on nouveau drivers HOT 1
- hardware accelerator failed to decode picture HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libvdpau-va-gl.